Miner -> staker in contracts#1020
Merged
KPrasch merged 3 commits intonucypher:alhambra-verdefrom May 30, 2019
Merged
Conversation
KPrasch
reviewed
May 28, 2019
This was referenced May 29, 2019
Merged
cygnusv
approved these changes
May 30, 2019
| In order to become a participant of the network, a miner stakes tokens in the `MinersEscrow` contract. | ||
| The miner allows the (mining) contract to perform a transaction using the `NuCypherToken.approve(address, uint256)` method | ||
| In order to become a participant of the network, a staker stakes tokens in the `StakingEscrow` contract. | ||
| The staker allows the (mining) contract to perform a transaction using the `NuCypherToken.approve(address, uint256)` method |
Member
There was a problem hiding this comment.
What do you mean here by the "(mining) contract"?
| Stakers can claim their rewards by using the `StakingEscrow.withdraw(uint256)` method. Only non-locked tokens can be withdrawn. | ||
|
|
||
|
|
||
| ### Ursula Generates Policy Rewards |
Member
There was a problem hiding this comment.
Isn't better to call this "fees" instead of "rewards"? What do you think @michwill ?
Member
Author
There was a problem hiding this comment.
Hmm, I thought fee for policy and reward for staking
Codecov Report
@@ Coverage Diff @@
## alhambra-verde #1020 +/- ##
===================================================
- Coverage 85.05% 67.54% -17.52%
===================================================
Files 65 65
Lines 7925 7925
===================================================
- Hits 6741 5353 -1388
- Misses 1184 2572 +1388
Continue to review full report at Codecov.
|
KPrasch
approved these changes
May 30, 2019
cygnusv
pushed a commit
to cygnusv/nucypher
that referenced
this pull request
Jun 4, 2019
Miner -> staker in contracts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #949
Renames miner to staker in solidity contracts and in tests for them.
Refs #800