Implement feedback from nucypher-core integration#119
Merged
piotr-roslaniec merged 12 commits intomainfrom Jun 2, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## expose-bindings-from-main-crate #119 +/- ##
===================================================================
- Coverage 77.50% 77.41% -0.10%
===================================================================
Files 24 24
Lines 4935 4968 +33
===================================================================
+ Hits 3825 3846 +21
- Misses 1110 1122 +12
|
theref
approved these changes
May 29, 2023
This was referenced May 30, 2023
derekpierre
reviewed
Jun 2, 2023
| black_box, criterion_group, criterion_main, BenchmarkId, Criterion, | ||
| }; | ||
| use group_threshold_cryptography::{ | ||
| use group_threshold_cryptography_pre_release::{ |
Member
There was a problem hiding this comment.
Do we intend to keep this crate name as _pre_release?
Author
There was a problem hiding this comment.
No, I will have these dependencies properly renamed and released during the stable ferveo release. Releasing *-pre-release crates was an exercise in preparing the stable release.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #118. Please review it first.
Type of PR:
Required reviews:
What this does:
ferveocrate nucypher-core#53PublicKeytoFerveoPublicKeyandencrypttoferveoEncryptin WASM bindings to avoid WASM symbol conflict withrust-umbralWASM symbols*-pre-releasepackages for convenience, updates package metadataIssues fixed/closed:
ferveocrate nucypher-core#53Why it's needed:
ferveoand its bindingsNotes for reviewers:
PublicKeytoFerveoPublicKeyacross the codebase?