Integrate with ferveo crate#53
Conversation
|
Is it possible to make submodules somehow? Is it a thing in JS? |
|
Yes, you can implement modules in JS. For example, you can group your exports like this: I'm not sure how to do it in |
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 15.24% 15.25% +0.01%
==========================================
Files 16 16
Lines 2841 2845 +4
==========================================
+ Hits 433 434 +1
- Misses 2408 2411 +3
|
2e88a1c to
6a4da8f
Compare
6a4da8f to
66d7984
Compare
|
Ok, I just realized this is a known issue: Should be fixed by updating |
e8e355e to
ba534c6
Compare
ba534c6 to
8c296b8
Compare
950953f to
0f40ac5
Compare
0f40ac5 to
7770623
Compare
|
Hi @derekpierre, just wanted to check in with you. Are there any other TODOs that should be covered here? |
Perhaps this one as well? https://github.com/piotr-roslaniec/nucypher-core/blob/ferveo-types/nucypher-core/src/lib.rs#L51. Also adding @KPrasch as a reviewer. -- Do these changes need an related update on the |
| ritual_id: u16, | ||
| variant: u8, | ||
| ciphertext: &[u8], // TODO use ferveo Ciphertext type | ||
| ciphertext: &Ciphertext, |
There was a problem hiding this comment.
This change is supremely satisfying to see!

ferveoare tracked here: Implement feedback fromnucypher-coreintegration ferveo#119PublicKeytoUmbralPublicKeyandFerveoPublicKeyrespectively? Technically, it's sufficient to rename one of them,FerveoPublicKey.FerveoPublicKey