Skip to content

Expose language bindings as features from ferveo crate#118

Merged
piotr-roslaniec merged 15 commits intomainfrom
expose-bindings-from-main-crate
Jun 2, 2023
Merged

Expose language bindings as features from ferveo crate#118
piotr-roslaniec merged 15 commits intomainfrom
expose-bindings-from-main-crate

Conversation

@piotr-roslaniec
Copy link
Copy Markdown

@piotr-roslaniec piotr-roslaniec commented May 22, 2023 •
edited
Loading

Based on #114 - Please review it first.

Type of PR:

  • Refactor

Required reviews:

  • 1

What this does:

  • Performs steps necessary for integration with nucypher-core as described in Prepare for integration with nucypher-core #112
  • Language bindings are now exposed from ferveo crate as bindings_wasm and bindings_python features, similarly how rust-umbral does it

Issues fixed/closed:

Why it's needed:

  • To use ferveo types directly in nucypher-core

Notes for reviewers:

  • This a refactor and reconfiguration of existing crates
  • No functional changes

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2023

Codecov Report

Merging #118 (591c05e) into main (d246995) will decrease coverage by 1.95%.
The diff coverage is 34.05%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   79.45%   77.50%   -1.95%     
==========================================
  Files          23       24       +1     
  Lines        4809     4935     +126     
==========================================
+ Hits         3821     3825       +4     
- Misses        988     1110     +122
Impacted Files Coverage Δ
ferveo-common/src/lib.rs 100.00% <ø> (ø)
ferveo/src/bindings_wasm.rs 0.00% <0.00%> (ø)
ferveo/src/pvss.rs 91.68% <ø> (ø)
ferveo/src/utils.rs 94.73% <ø> (ø)
ferveo-python/src/lib.rs 1.28% <1.75%> (-62.89%) ⬇️
ferveo/src/bindings_python.rs 59.36% <59.36%> (ø)
ferveo-wasm/src/lib.rs 100.00% <100.00%> (+99.72%) ⬆️
ferveo/src/dkg.rs 95.49% <100.00%> (ø)
ferveo/src/lib.rs 97.40% <100.00%> (ø)
tpke/src/ciphertext.rs 89.41% <100.00%> (-0.06%) ⬇️
... and 1 more

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review May 22, 2023 13:48
@piotr-roslaniec piotr-roslaniec self-assigned this May 22, 2023
@piotr-roslaniec piotr-roslaniec mentioned this pull request May 29, 2023
Merged
@piotr-roslaniec piotr-roslaniec merged commit 11d6cea into main Jun 2, 2023
@piotr-roslaniec piotr-roslaniec deleted the expose-bindings-from-main-crate branch June 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPrasch KPrasch Awaiting requested review from KPrasch

@theref theref Awaiting requested review from theref

@derekpierre derekpierre Awaiting requested review from derekpierre

Assignees

@piotr-roslaniec piotr-roslaniec

Labels

None yet

Projects

v7.0.0 (TACo)
Status: Completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update crates to Rust 2021 edition Expose language bindings as features from ferveo crate Domain specific API integration into nucypher-core

2 participants

@piotr-roslaniec @codecov-commenter