SDK 15 by roman-khimov · Pull Request #3606 · nspcc-dev/neofs-node

roman-khimov · 2025-09-30T15:20:35Z

No description provided.

codecov · 2025-09-30T15:32:28Z

Codecov Report

❌ Patch coverage is 16.31579% with 159 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.66%. Comparing base (582380b) to head (1a88d82).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/services/object/server.go	6.72%	110 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/put.go	18.75%	26 Missing ⚠️
pkg/services/object/put/distributed.go	57.14%	8 Missing and 1 partial ⚠️
cmd/neofs-cli/internal/common/exit.go	0.00%	6 Missing ⚠️
pkg/services/object/acl/v2/service.go	45.45%	6 Missing ⚠️
cmd/neofs-node/meta.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   26.69%   26.66%   -0.04%     
==========================================
  Files         655      655              
  Lines       49744    49866     +122     
==========================================
+ Hits        13281    13296      +15     
- Misses      35415    35522     +107     
  Partials     1048     1048

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

carpawell

Do we need additional support in neofs-cli?

neofs-node/cmd/neofs-cli/internal/common/exit.go

Lines 27 to 50 in 582380b

    
           const ( 
        
           	_ = iota 
        
           	internal 
        
           	aclDenied 
        
           	awaitTimeout 
        
           	alreadyRemoved 
        
           ) 
        
           var code int 
        
           var accessErr = new(sdkstatus.ObjectAccessDenied) 
        
           switch { 
        
           case errors.Is(err, sdkstatus.ErrServerInternal): 
        
           	code = internal 
        
           case errors.As(err, &accessErr): 
        
           	code = aclDenied 
        
           	err = fmt.Errorf("%w: %s", err, accessErr.Reason()) 
        
           case errors.Is(err, ErrAwaitTimeout) || errors.Is(err, waiter.ErrConfirmationTimeout): 
        
           	code = awaitTimeout 
        
           case errors.Is(err, sdkstatus.ErrObjectAlreadyRemoved): 
        
           	code = alreadyRemoved 
        
           default: 
        
           	code = internal 
        
           }

CHANGELOG.md

pkg/services/object/server.go

pkg/services/object/put/distributed.go

Signed-off-by: Roman Khimov <roman@nspcc.ru>

Pool depletion cases. Signed-off-by: Roman Khimov <roman@nspcc.ru>

carpawell · 2025-10-01T09:33:20Z

Do we need additional support in neofs-cli?

What about this anyway? Busy and BadRequest look like common statuses that deserve a separate exit code.

roman-khimov · 2025-10-01T09:49:15Z

We have a lot of other codes as well, but we only check for some specific ones in CLI. I don't have any strict preferences here for now.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov · 2025-10-01T10:12:53Z

Added incomplete/busy codes to CLI.

carpawell · 2025-10-01T10:16:07Z

docs/cli-exit-codes.md

 | 2         | Object access denied or unauthorized.          |
 | 3         | Await timeout expired for a certain condition. |
 | 4         | Object already removed.                        |
+| 5         | Incomplete success (like partial PUT or SEARCH).|


not aligned now

Intentional. It's not worth changing all lines here.

Inspired by https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/4114-1759404161/index.html. Accompanied by nspcc-dev/neofs-testcases#1160. Triggered by #3606.

An omission of #3606. Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov requested review from End-rey, carpawell and cthulhu-rider as code owners September 30, 2025 15:20

roman-khimov force-pushed the sdk15 branch from 40f083a to 3084f5f Compare September 30, 2025 15:25

roman-khimov force-pushed the sdk15 branch 2 times, most recently from ba4b131 to 3609481 Compare September 30, 2025 16:12

carpawell reviewed Sep 30, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pkg/services/object/server.go Outdated Show resolved Hide resolved

pkg/services/object/put/distributed.go Outdated Show resolved Hide resolved

roman-khimov added 3 commits September 30, 2025 22:14

go.mod: upgrade to SDK RC15

bda0316

Signed-off-by: Roman Khimov <roman@nspcc.ru>

acl: drop named return variables from findRequestInfo

9cdba27

Signed-off-by: Roman Khimov <roman@nspcc.ru>

*: return ErrBusy to client where appropriate

8843cbd

Pool depletion cases. Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov force-pushed the sdk15 branch from 3609481 to f32a235 Compare September 30, 2025 19:15

roman-khimov added 4 commits October 1, 2025 13:08

object: return Incomplete status on search failures, fix #2721

3f4bade

Signed-off-by: Roman Khimov <roman@nspcc.ru>

put: return incomplete status and OID when appropriate, fix #3428

e0fc6ac

Signed-off-by: Roman Khimov <roman@nspcc.ru>

object: return BadRequest where appropriate

c7d99f8

Signed-off-by: Roman Khimov <roman@nspcc.ru>

cli: extend return codes for incomplete and busy statuses

1a88d82

Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov force-pushed the sdk15 branch from f32a235 to 1a88d82 Compare October 1, 2025 10:12

roman-khimov requested a review from carpawell October 1, 2025 10:12

carpawell approved these changes Oct 1, 2025

View reviewed changes

roman-khimov merged commit 900e0a7 into master Oct 2, 2025
16 of 21 checks passed

roman-khimov deleted the sdk15 branch October 2, 2025 09:39

roman-khimov mentioned this pull request Oct 2, 2025

Test fixes #3610

Merged

roman-khimov added a commit that referenced this pull request Oct 2, 2025

Test fixes (#3610)

675fccd

Inspired by https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/4114-1759404161/index.html. Accompanied by nspcc-dev/neofs-testcases#1160. Triggered by #3606.

roman-khimov mentioned this pull request Nov 18, 2025

Can't searchv2 in container when one node is down #3678

Closed

roman-khimov added a commit that referenced this pull request Nov 18, 2025

object: return incomplete status properly for DELETE operation

52c4cda

An omission of #3606. Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov added a commit that referenced this pull request Nov 18, 2025

object: return incomplete status properly for DELETE operation

5649499

An omission of #3606. Signed-off-by: Roman Khimov <roman@nspcc.ru>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK 15#3606

SDK 15#3606
roman-khimov merged 7 commits intomasterfrom
sdk15

roman-khimov commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

carpawell left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carpawell commented Oct 1, 2025 •

edited

Loading

Uh oh!

roman-khimov commented Oct 1, 2025

Uh oh!

roman-khimov commented Oct 1, 2025

Uh oh!

carpawell Oct 1, 2025

Uh oh!

roman-khimov Oct 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const (
	_ = iota
	internal
	aclDenied
	awaitTimeout
	alreadyRemoved
	)

	var code int
	var accessErr = new(sdkstatus.ObjectAccessDenied)

	switch {
	case errors.Is(err, sdkstatus.ErrServerInternal):
	code = internal
	case errors.As(err, &accessErr):
	code = aclDenied
	err = fmt.Errorf("%w: %s", err, accessErr.Reason())
	case errors.Is(err, ErrAwaitTimeout) \|\| errors.Is(err, waiter.ErrConfirmationTimeout):
	code = awaitTimeout
	case errors.Is(err, sdkstatus.ErrObjectAlreadyRemoved):
	code = alreadyRemoved
	default:
	code = internal
	}

Conversation

roman-khimov commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

carpawell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carpawell commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roman-khimov commented Oct 1, 2025

Uh oh!

roman-khimov commented Oct 1, 2025

Uh oh!

carpawell Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

roman-khimov Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Sep 30, 2025 •

edited

Loading

carpawell commented Oct 1, 2025 •

edited

Loading