Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3610 +/- ##
==========================================
- Coverage 26.66% 26.59% -0.08%
==========================================
Files 655 653 -2
Lines 49866 50002 +136
==========================================
+ Hits 13296 13297 +1
- Misses 35521 35656 +135
Partials 1049 1049 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
After c7d99f8 these all became BadRequest while they were all ServerInternal. Neither are appropriate in most cases, it's not a server that is bad, it's not a request that is bad. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This:
can't search for LOCK objects: status: code = 1 message = last error: all endpoints failed, first error: /dns4/localhost/tcp/49270: send request over gRPC: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:49270: connect: connection refused"
looks like a total node failure while in fact it's just about a single other
node that we can mention explicitly.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
08cb2d9 to
c9b3f14
Compare
It never worked correctly (since 1ac26db), now 3f4bade exposed this leading to test failures like: rpc error: deleting 2UuJ5D8WGqvdt6oF7JwZBRQCQdvaycyRdD2FYciHSHdN object: remove object via client: status: code = 1 message = last error: /dns4/localhost/tcp/60925: status: code = 1026 message = incorrect number of verification headers Signed-off-by: Roman Khimov <roman@nspcc.ru>
c9b3f14 to
f707718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/4114-1759404161/index.html.
Accompanied by nspcc-dev/neofs-testcases#1160.
Triggered by #3606.