Skip to content

Unify line ending terminology#2141

Closed
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
dail8859:eol-terminology
Closed

Unify line ending terminology#2141
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
dail8859:eol-terminology

Conversation

@dail8859
Copy link
Copy Markdown
Contributor

@dail8859 dail8859 commented Aug 3, 2016

Closes #2038

Currently there are inconsistencies when using EOL terminology. I have changed occurrences to use (and maintain this order):

  • Windows (CR LF)
  • Unix (LF)
  • Macintosh (CR)

I am open to suggestions but I feel this is fairly straight forward, unambiguous, and this is exactly how MSVC displays them in their menu.

Before:

menu
settings
bar


After:
menu_after
settings_after
after_bar

@donho donho added the accepted label Aug 9, 2016
@donho donho added this to the 6.x milestone Aug 9, 2016
@dail8859 dail8859 closed this in a21196d Aug 9, 2016
@dail8859 dail8859 deleted the eol-terminology branch August 9, 2016 23:30
@vlakoff
Copy link
Copy Markdown
Contributor

vlakoff commented Aug 14, 2016

We should emphasize that Macintosh actually uses LF.

Maybe we could just drop the CR option?

@Eldaw
Copy link
Copy Markdown

Eldaw commented Aug 23, 2016

I submitted an excellent pull request some time back to address this issue, which also addressed the fact that Macintosh uses LF (by calling the CR one 'Classic Mac'). Unfortunately it was rejected by @donho for a reason that made no sense.
#787

@vlakoff
Copy link
Copy Markdown
Contributor

vlakoff commented Aug 24, 2016

How about this?

Windows (CR LF)
Unix / Mac (LF)
Old Mac (CR)

The important part is to not trick Mac users into using CR.
Also, many Mac users probably don't know they are using a Unix system.

@dail8859
Copy link
Copy Markdown
Contributor Author

@Eldaw Interesting...never realized there was a PR so similar.

I'm not attached to the terminology I used, it's what Visual Studio used so figured it was an OK way of doing it. I understand that VS is targeted to a more technical audience than N++ is. Presumably in the majority of cases (not all) if a user is converting line endings they have some idea what line endings they want even without terminology.

I think it is important to keep the CR/LF/CRLF terminology that way if someone disagrees with the naming scheme they can at least know exactly what line endings they are converting to.

The important part is to not trick Mac users into using CR.
Also, many Mac users probably don't know they are using a Unix system.

I totally agree, however most Mac users probably don't know the difference between "Mac" vs "Old Mac" (although maybe they do? I'm not a Mac person :) ).

@vlakoff
Copy link
Copy Markdown
Contributor

vlakoff commented Aug 24, 2016

I totally agree, however most Mac users probably don't know the difference between "Mac" vs "Old Mac" (although maybe they do? I'm not a Mac person :) ).

Agree, I just tried to get a concise result, and I got not satisfying result using "Mac OS X" or "OS X".

That's why I suggested above to remove the CR mode.
Useless (unless proven otherwise), no more confusion to worry about.

SinghRajenM pushed a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants