Skip to content

bump: bump up and vote notation v1.1.1 #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeyJeyGao merged 1 commit into from
Jun 12, 2024
Merged

bump: bump up and vote notation v1.1.1 #963

JeyJeyGao merged 1 commit into from
Jun 12, 2024

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jun 11, 2024 •
edited
Loading

Release

This would mean tagging 3dafd53 v1.1.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.1.1.

Changes

The code changes compared to v1.1.0 include:

Full Changelog: v1.1.0...3dafd53

Resolve part of #947

@codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (268734f) to head (3dafd53).

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.1     #963   +/-   ##
============================================
  Coverage        71.30%   71.30%           
============================================
  Files               45       45           
  Lines             2171     2171           
============================================
  Hits              1548     1548           
  Misses             429      429           
  Partials           194      194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao marked this pull request as ready for review June 11, 2024 05:17
@JeyJeyGao JeyJeyGao requested a review from a user June 11, 2024 05:17
ghost
ghost previously approved these changes Jun 11, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jun 11, 2024

LGTM. Do you also want to port #960 to release v1.1.1?

@JeyJeyGao JeyJeyGao changed the title bump: bump up and vote notation v1.1.1 bump: bump up dependencies and vote notation v1.1.1 Jun 11, 2024
@JeyJeyGao
Copy link
Contributor Author

JeyJeyGao commented Jun 11, 2024

LGTM. Do you also want to port #960 to release v1.1.1?

Updated.

@JeyJeyGao JeyJeyGao requested a review from a user June 11, 2024 07:01
@JeyJeyGao JeyJeyGao changed the title bump: bump up dependencies and vote notation v1.1.1 [Draft] bump: bump up dependencies and vote notation v1.1.1 Jun 11, 2024
@JeyJeyGao JeyJeyGao marked this pull request as draft June 11, 2024 07:40
@JeyJeyGao JeyJeyGao changed the title [Draft] bump: bump up dependencies and vote notation v1.1.1 bump: bump up dependencies and vote notation v1.1.1 Jun 11, 2024
@priteshbandi
Copy link
Contributor

priteshbandi commented Jun 11, 2024

LGTM

@JeyJeyGao JeyJeyGao marked this pull request as ready for review June 12, 2024 01:04
@JeyJeyGao
bump: notation v1.1.1
3dafd53 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title bump: bump up dependencies and vote notation v1.1.1 bump: bump up and vote notation v1.1.1 Jun 12, 2024
shizhMSFT
shizhMSFT approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yizha1
yizha1 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 1b206a3 into notaryproject:release-1.1 Jun 12, 2024
@JeyJeyGao JeyJeyGao mentioned this pull request Oct 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@yizha1 yizha1 yizha1 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JeyJeyGao @shizhMSFT @priteshbandi @yizha1