Skip to content

Conversation

@JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao requested a review from a user June 3, 2024 05:59
@JeyJeyGao JeyJeyGao changed the title bump: bump up notation-go v1.1.1 bump: bump up notation-go v1.1.1 and other dependencies Jun 3, 2024
@codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (b6dca32) to head (b3ad7e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          45       45           
  Lines        2174     2174           
=======================================
  Hits         1551     1551           
  Misses        429      429           
  Partials      194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT previously approved these changes Jun 3, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the dependencies in test/e2e. They are test/e2e/go.mod and test/e2e/plugin/go.mod.

priteshbandi
priteshbandi previously approved these changes Jun 3, 2024
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
Copy link
Contributor Author

We should also update the dependencies in test/e2e. They are test/e2e/go.mod and test/e2e/plugin/go.mod.

Updated.

@JeyJeyGao JeyJeyGao requested review from a user, priteshbandi and shizhMSFT June 4, 2024 01:23
@ghost
Copy link

ghost commented Jun 4, 2024

LGTM, but waiting for the DCO status.

@JeyJeyGao JeyJeyGao closed this Jun 4, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 4, 2024
@JeyJeyGao JeyJeyGao closed this Jun 4, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 4, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao closed this Jun 5, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 5, 2024
@JeyJeyGao JeyJeyGao closed this Jun 5, 2024
@JeyJeyGao JeyJeyGao reopened this Jun 5, 2024
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao merged commit 6e89dd7 into notaryproject:main Jun 6, 2024
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…t#952)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…t#952)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants