feat: notation plugin install command #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 19, 2023 16:50
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 64.39% 63.59% -0.80%
==========================================
Files 42 45 +3
Lines 2390 2692 +302
==========================================
+ Hits 1539 1712 +173
- Misses 720 824 +104
- Partials 131 156 +25 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Nov 8, 2023
shizhMSFT
reviewed
Nov 8, 2023
JeyJeyGao
reviewed
Nov 20, 2023
JeyJeyGao
reviewed
Nov 20, 2023
JeyJeyGao
reviewed
Nov 20, 2023
shizhMSFT
reviewed
Nov 20, 2023
added 3 commits
December 20, 2023 10:30
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 3 commits
December 21, 2023 08:44
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 21, 2023
priteshbandi
approved these changes
Dec 21, 2023
Contributor
priteshbandi
left a comment
There was a problem hiding this comment.
LGTM.
We should track all the open comments in an issue and address them before 1.1 release
Author
|
@priteshbandi As discussed, issue created: #853 |
This was referenced Jan 4, 2024
6 tasks
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the new spec: #809
It supports following notation plugin installations:
.tar.gz/.zipfile in file systemHTTPS URL, SHA256 checksum is requiredTest: Corresponding E2E test cases are added in this PR as well.
Note: This PR depends on the notation-go PR: notaryproject/notation-go#364The notation-go PR: notaryproject/notation-go#364 has been Merged.