-
Notifications
You must be signed in to change notification settings - Fork 91
doc: update plugin spec #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 64.09% 64.05% -0.05%
==========================================
Files 40 40
Lines 2284 2323 +39
==========================================
+ Hits 1464 1488 +24
- Misses 698 709 +11
- Partials 122 126 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
yizha1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FeynmanZhou . I did a first round review, will take another pass later.
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
|
@rgnote @priteshbandi @iamsamirzon Would you mind reviewing the notation plugin mgmt spec updates? Thanks |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yizha1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but IANAM
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
priteshbandi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is based on the spec PR: #809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Update notation plugin spec based on #549 and PRD
Added new commands and examples including:
Updated the output of
notation plugin list.