Skip to content

Conversation

@FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Oct 27, 2023

Update notation plugin spec based on #549 and PRD

Added new commands and examples including:

  • notation plugin install Install a plugin
  • notation plugin ninstall Uninstall a plugin

Updated the output of notation plugin list.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31c9e84) 64.09% compared to head (9481477) 64.05%.
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   64.09%   64.05%   -0.05%     
==========================================
  Files          40       40              
  Lines        2284     2323      +39     
==========================================
+ Hits         1464     1488      +24     
- Misses        698      709      +11     
- Partials      122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested a review from a user November 1, 2023 09:17
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou . I did a first round review, will take another pass later.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou
Copy link
Member Author

@rgnote @priteshbandi @iamsamirzon Would you mind reviewing the notation plugin mgmt spec updates? Thanks

@FeynmanZhou FeynmanZhou requested review from a user, shizhMSFT and yizha1 November 6, 2023 15:35
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested a review from a user November 17, 2023 03:53
ghost
ghost previously approved these changes Nov 17, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yizha1
yizha1 previously approved these changes Nov 17, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou dismissed stale reviews from yizha1 and ghost via 54d8f85 November 17, 2023 09:48
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@ghost ghost mentioned this pull request Nov 20, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 2bfcee6 into notaryproject:main Nov 20, 2023
priteshbandi pushed a commit that referenced this pull request Dec 5, 2023
This PR is based on the spec PR: #809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost mentioned this pull request Jan 25, 2024
6 tasks
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou added a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants