Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 12, 2023

Resolves #706

This PR should be reviewed/merged after notaryproject/notation-core-go#154.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost self-assigned this Jul 12, 2023
@ghost ghost added the enhancement New feature or request label Jul 12, 2023
@ghost ghost added this to the 1.0.0 milestone Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.66%. Comparing base (a685f69) to head (0015e5f).
⚠️ Report is 333 commits behind head on main.

❌ Your project status has failed because the head coverage (63.66%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   63.66%   63.66%           
=======================================
  Files          40       40           
  Lines        2232     2232           
=======================================
  Hits         1421     1421           
  Misses        690      690           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shizhMSFT
shizhMSFT previously approved these changes Jul 12, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@ghost ghost changed the title feat: add license header to files and github action workflow to check license chore: add license header to files and github action workflow to check license Jul 12, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 2 commits July 12, 2023 19:10
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT July 12, 2023 11:23
priteshbandi
priteshbandi previously approved these changes Jul 12, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Jul 13, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR must be merged after notaryproject/notation-core-go#154

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost dismissed stale reviews from shizhMSFT and priteshbandi via 7453b89 July 18, 2023 02:28
@ghost ghost requested review from priteshbandi and shizhMSFT July 18, 2023 02:29
JeyJeyGao
JeyJeyGao previously approved these changes Jul 18, 2023
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested a review from JeyJeyGao July 18, 2023 06:11
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 57a0a6e into notaryproject:main Jul 18, 2023
@ghost ghost deleted the license branch July 19, 2023 02:36
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…k license (notaryproject#739)

Resolves notaryproject#706

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
…k license (notaryproject#739)

Resolves notaryproject#706

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check the license header for Notation and its dependencies

4 participants