Skip to content

chore: add license header to files and github action workflow to check license #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6 commits merged into from Jul 18, 2023
Merged

chore: add license header to files and github action workflow to check license #154

6 commits merged into from Jul 18, 2023

Conversation

@ghost
Copy link

@ghost ghost commented Jul 12, 2023 •
edited by ghost
Loading

Resolves #149

Patrick Zheng added 3 commits July 12, 2023 13:25
adding license headers
ffb1813 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added license headers
a860ba0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added check license
5a5b81d 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost changed the title feat: add license headers to files and github action workflow to check lincese feat: add license header to files and github action workflow to check lincese Jul 12, 2023
@ghost ghost self-assigned this Jul 12, 2023
@ghost ghost added the enhancement New feature or request label Jul 12, 2023
@ghost ghost added this to the 1.0.0 milestone Jul 12, 2023
@ghost ghost changed the title feat: add license header to files and github action workflow to check lincese feat: add license header to files and github action workflow to check license Jul 12, 2023
shizhMSFT
shizhMSFT previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@ghost ghost changed the title feat: add license header to files and github action workflow to check license chore: add license header to files and github action workflow to check license Jul 12, 2023
using reusable workflow
a5e97d6 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #154 (27c03d0) into main (02fc54a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          21       21           
  Lines        1693     1693           
=======================================
  Hits         1509     1509           
  Misses        149      149           
  Partials       35       35
Impacted Files Coverage Δ
revocation/ocsp/errors.go 100.00% <ø> (ø)
revocation/ocsp/ocsp.go 81.39% <ø> (ø)
revocation/result/errors.go 100.00% <ø> (ø)
revocation/result/results.go 100.00% <ø> (ø)
revocation/revocation.go 100.00% <ø> (ø)
signature/algorithm.go 100.00% <ø> (ø)
signature/cose/envelope.go 93.24% <ø> (ø)
signature/envelope.go 100.00% <ø> (ø)
signature/errors.go 94.73% <ø> (ø)
signature/internal/base/envelope.go 97.72% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost ghost requested a review from shizhMSFT July 12, 2023 11:15
This was referenced Jul 12, 2023
Merged
Merged
shizhMSFT
shizhMSFT approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT requested changes Jul 13, 2023
View reviewed changes
Patrick Zheng added 2 commits July 13, 2023 15:30
removed release branch from license checker
c2fdd32 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
clean up
27c03d0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT July 13, 2023 07:54
shizhMSFT
shizhMSFT approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6a0651c into notaryproject:main Jul 18, 2023
@ghost ghost deleted the license branch July 18, 2023 02:03
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
Closed
6 tasks
fanndu pushed a commit to fanndu/notation-core-go that referenced this pull request Jul 21, 2023
@fanndu
chore: add license header to files and github action workflow to chec…
9d7e24a 
…k license (notaryproject#154)
fanndu pushed a commit to fanndu/notation-core-go that referenced this pull request Jul 21, 2023
@fanndu
chore: add license header to files and github action workflow to chec…
3427146 
…k license (notaryproject#154)

Signed-off-by: fanndu <dufann@hotmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Check the license header for notation-core-go and its dependencies

4 participants

@codecov-commenter @priteshbandi @shizhMSFT @JeyJeyGao