Skip to content

Conversation

@7h3-3mp7y-m4n
Copy link
Contributor

@7h3-3mp7y-m4n 7h3-3mp7y-m4n commented Mar 14, 2025

This PR adds a link to the "Contributing Guide" section in the README file, providing contributors with easy access to the project's contributing guidelines.
fix #1224

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @7h3-3mp7y-m4n

@FeynmanZhou FeynmanZhou linked an issue Mar 15, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (7d8e4e1) to head (c6f7a17).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   76.46%   76.54%   +0.08%     
==========================================
  Files          67       67              
  Lines        3696     3710      +14     
==========================================
+ Hits         2826     2840      +14     
  Misses        671      671              
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeyJeyGao
Copy link
Contributor

@7h3-3mp7y-m4n Please sign your git commit. Thanks!

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@FeynmanZhou
Copy link
Member

Now the commit has been signed. Thanks @7h3-3mp7y-m4n

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 73a4da6 into notaryproject:main Mar 27, 2025
7 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Link to the Contributing.md in the README

3 participants