Skip to content

bump: release v1.3.0-rc.1 #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from Oct 9, 2024
Merged

bump: release v1.3.0-rc.1 #1056

1 commit merged into from Oct 9, 2024

Conversation

@ghost
Copy link

@ghost ghost commented Oct 8, 2024 •
edited by priteshbandi
Loading

Release

This would mean tagging 0d9ceac as v1.3.0-rc.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release v1.3.0-rc.1.

What's Changed

Full Changelog: v1.2.0...0d9ceac

Actions

Please review the PR and vote by approving.

bump: release v1.3.0-rc.1
0d9ceac 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (2819637) to head (0d9ceac).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.3    #1056   +/-   ##
============================================
  Coverage        72.00%   72.00%           
============================================
  Files               46       46           
  Lines             2300     2300           
============================================
  Hits              1656     1656           
  Misses             442      442           
  Partials           202      202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Oct 8, 2024

LGTM

shizhMSFT
shizhMSFT approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit de974f8 into notaryproject:release-1.3 Oct 9, 2024
@ghost ghost deleted the release-1.3 branch October 9, 2024 02:07
@ghost ghost mentioned this pull request Dec 30, 2024
Merged
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@priteshbandi @shizhMSFT @JeyJeyGao