Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 26, 2024

This PR is for release-1.3 branch.

It cherry picks commit from v1.2 to remove blob sign/verify for v1.3.0-rc.1 release.

For easier review, please see https://github.com/notaryproject/notation/compare/v1.2.0..ec32bef8a58dce5447e8be43f655fe457b8272ad for your reference.

@ghost ghost changed the title refactor!: removed blob sign/verify for v1.3.0-rc.1 release refactor!: remove blob sign/verify for v1.3.0-rc.1 release Sep 26, 2024
@ghost ghost marked this pull request as draft September 26, 2024 05:35
@ghost ghost marked this pull request as ready for review September 27, 2024 00:59
@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (4c0a3da) to head (ec32bef).
Report is 1 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3    #1045   +/-   ##
============================================
  Coverage        72.00%   72.00%           
============================================
  Files               46       46           
  Lines             2300     2300           
============================================
  Hits              1656     1656           
  Misses             442      442           
  Partials           202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT previously approved these changes Sep 27, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested a review from shizhMSFT October 7, 2024 23:59
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Patrick Zheng added 5 commits October 8, 2024 10:37
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost merged commit 2819637 into notaryproject:release-1.3 Oct 8, 2024
@ghost ghost deleted the release-1.3 branch October 8, 2024 02:48
@ghost ghost mentioned this pull request Oct 8, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants