Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 23, 2024

This PR enables crl revocation with file cache during verification.

Tested on Unix and Windows.

Patrick Zheng added 3 commits September 23, 2024 13:51
crl
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (c2cff5b) to head (b95014e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/notation/verify.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   72.01%   72.00%   -0.02%     
==========================================
  Files          46       46              
  Lines        2287     2300      +13     
==========================================
+ Hits         1647     1656       +9     
- Misses        440      442       +2     
- Partials      200      202       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost closed this Sep 24, 2024
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost reopened this Sep 24, 2024
Patrick Zheng added 2 commits September 24, 2024 09:56
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits September 25, 2024 13:02
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested a review from shizhMSFT September 26, 2024 02:09
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 4c0a3da into notaryproject:main Sep 26, 2024
@ghost ghost deleted the crl branch September 26, 2024 04:58
@ghost ghost mentioned this pull request Oct 8, 2024
6 tasks
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants