Resolve old_path in uvwasi_path_symlink()#303
Merged
cjihrig merged 1 commit intonodejs:mainfrom May 29, 2025
Merged
Conversation
Contributor
Author
|
@ospencer Hi, sorry to bother you. I'm not sure if you are able to approve and/or merge this PR, but you are my only contact related to uvwasi. I hope you can help review this PR and possibly approve and merge it. Thanks a lot. |
Collaborator
|
@lum1n0us the CI is failing. |
- add test-symlink-outbox
e18da63 to
1b2ab00
Compare
Contributor
Author
|
I've fixed the unused variables errors in uvwasi CI / ubuntu-latest - debug-log. The other two seem related to infrastructure. From Build Fuzzers(address). https://github.com/nodejs/uvwasi/actions/runs/15101901324/job/43082367465?pr=303 AND. From Test Coverage. https://github.com/nodejs/uvwasi/actions/runs/15101901326/job/43082367566?pr=303 BTW, Is there a way I can re-run the CI or trigger it without bothering you? |
cjihrig
approved these changes
May 29, 2025
Collaborator
It might work on future PRs now that you're no longer a first time contributor. |
Merged
aduh95
added a commit
that referenced
this pull request
Sep 2, 2025
Notable changes: - Disallow malformed path with null byte (#266) (7aaa0b4) - Preserve trailing slash in file path (#268) (afffaaa) - Disallow absolute path at the raw WASI level (#270) (9811374) - Error if creating symlink to absolute path (#272) (c8d4f01) - Add cflite and document normalize path (#280) (6eeddba) - Resolve old_path in uvwasi_path_symlink() (#303) (98da5ad) - Use index rather than `telldir`/`seekdir` to represent `fd_readdir` cookie (#298) (392e1f1) - fix: static library name (#305) (146e516) - fix: do not put header files in a subfolders (#302) (ec28b58) - fix: explicitly export symbols (#308) (4e9b4e0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #299