Skip to content

Add cflite and document normalize path#280

Merged
mhdawson merged 3 commits intonodejs:mainfrom
DavidKorczynski:enable-cflite
Sep 16, 2024
Merged

Add cflite and document normalize path#280
mhdawson merged 3 commits intonodejs:mainfrom
DavidKorczynski:enable-cflite

Conversation

@DavidKorczynski
Copy link
Copy Markdown
Contributor

Resolving: #251 (comment)

I also added a ClusterFuzzLite integration with the harness described in the issue.

The harness will be run when PRs are made against uvwasi.

To run the harness manually locally:

git clone https://github.com/google/oss-fuzz
git clone https://github.com/DavidKorczynski/uvwasi
cd uvwasi
git checkout enable-cflite

# Build the fuzzers in .clusterfuzzlite
python3 ../oss-fuzz/infra/helper.py build_fuzzers --external $PWD

# Run the fuzzer for 10 seconds
python3 ../oss-fuzz/infra/helper.py run_fuzzer --external $PWD fuzz_normalize_path -- -max_total_time=10

Fixes: #251

Fixes: nodejs#251

Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Sep 5, 2024

@DavidKorczynski thanks, one more ask would be to add the instructions on how to run the fuzzers to the main readme. I think a section at the bottom titled 'Running the fuzzers locally' or something like that containing what you have in the description above would make it easier to find/run.

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with a suggestion

@DavidKorczynski
Copy link
Copy Markdown
Contributor Author

Overall LGTM with a suggestion

done

Signed-off-by: David Korczynski <david@adalogics.com>
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 6eeddba into nodejs:main Sep 16, 2024
@mhdawson
Copy link
Copy Markdown
Member

@DavidKorczynski thanks for the doc/contribution.

@aduh95 aduh95 mentioned this pull request Aug 16, 2025
aduh95 added a commit that referenced this pull request Sep 2, 2025
Notable changes:

- Disallow malformed path with null byte (#266) (7aaa0b4)
- Preserve trailing slash in file path (#268) (afffaaa)
- Disallow absolute path at the raw WASI level (#270) (9811374)
- Error if creating symlink to absolute path (#272) (c8d4f01)
- Add cflite and document normalize path (#280) (6eeddba)
- Resolve old_path in uvwasi_path_symlink() (#303) (98da5ad)
- Use index rather than `telldir`/`seekdir` to represent `fd_readdir` cookie (#298) (392e1f1)
- fix: static library name (#305) (146e516)
- fix: do not put header files in a subfolders (#302) (ec28b58)
- fix: explicitly export symbols (#308) (4e9b4e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write-based buffer overflow in uvwasi__normalize_path

2 participants