Fix docs links and add examples to sidebar #2895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2024 13:04
tastypackets
commented
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
Uzlopak
reviewed
Mar 1, 2024
metcoder95
approved these changes
Mar 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 85 85
Lines 23428 23428
=======================================
Hits 21979 21979
Misses 1449 1449 ☔ View full report in Codecov by Sentry. |
Uzlopak
previously approved these changes
Mar 3, 2024
Uzlopak
reviewed
Mar 3, 2024
Contributor
|
So? |
Ethan-Arrowood
approved these changes
Mar 5, 2024
Contributor
|
@Ethan-Arrowood Can we move the examples link to a much less dominant position? |
Collaborator
|
Doesn't matter to me one way or another. I'm hoping to change our doc site sooner than later anyways. |
Uzlopak
approved these changes
Mar 5, 2024
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
@Ethan-Arrowood
Can you approve and merge please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Docs
Rationale
Links should work
Changes
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status