Skip to content

perf(util/parseHeaders): If the header name is buffer#2501

Merged
ronag merged 34 commits intonodejs:mainfrom
tsctx:perf/improve-parseheaders-buffer
Dec 8, 2023
Merged

perf(util/parseHeaders): If the header name is buffer#2501
ronag merged 34 commits intonodejs:mainfrom
tsctx:perf/improve-parseheaders-buffer

Conversation

@tsctx
Copy link
Copy Markdown
Member

@tsctx tsctx commented Dec 6, 2023 •
edited
Loading

Fixes #2498

Benchmark

  • main
• parseHeaders
---------------------------------------------------------------- -----------------------------
parseHeaders               26.12 µs/iter    (21.1 µs … 19.62 ms)   22.5 µs   56.6 µs   72.6 µs
parseHeaders (irregular)   29.83 µs/iter    (25.9 µs … 874.1 µs)   29.3 µs   73.7 µs   80.4 µs

summary for parseHeaders
  parseHeaders
   1.14x faster than parseHeaders (irregular)
  • this patch
• parseHeaders
---------------------------------------------------------------- -----------------------------
parseHeaders               14.34 µs/iter    (12.5 µs … 436.2 µs)   13.3 µs   33.5 µs     45 µs
parseHeaders (irregular)   13.99 µs/iter    (12.4 µs … 368.8 µs)   13.1 µs   31.5 µs   39.9 µs

summary for parseHeaders
  parseHeaders (irregular)
   1.03x faster than parseHeaders

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina requested changes

@ronag ronag ronag approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@lemire lemire Awaiting requested review from lemire

@anonrig anonrig Awaiting requested review from anonrig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request to improve performance of stringifying in internal codes

7 participants

@tsctx @codecov-commenter @metcoder95 @ronag @lemire @anonrig @mcollina