Skip to content

feat: Optionally hook internal paths like require-in-the-middle#194

Merged
timfish merged 2 commits intonodejs:mainfrom
timfish:feat/patch-internals
May 24, 2025
Merged

feat: Optionally hook internal paths like require-in-the-middle#194
timfish merged 2 commits intonodejs:mainfrom
timfish:feat/patch-internals

Conversation

@timfish
Copy link
Contributor

@timfish timfish commented May 23, 2025

As discussed in the Diagnostics Working Group meeting, this PR is similar to #189 but allows this change to be selectively enabled so it can be tested more thoroughly before becoming the default.

Sentry are happy to do this testing!

@timfish timfish requested a review from jsumners-nr May 23, 2025 11:29
@timfish timfish assigned AbhiPrasad and unassigned AbhiPrasad May 23, 2025
@timfish timfish requested a review from AbhiPrasad May 23, 2025 11:44
jsumners-nr
jsumners-nr previously approved these changes May 23, 2025
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a note in the README

@timfish timfish merged commit 976d032 into nodejs:main May 24, 2025
50 of 51 checks passed
@timfish timfish deleted the feat/patch-internals branch December 16, 2025 20:23
trentm added a commit to trentm/import-in-the-middle that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants