fix: Hook internal paths like require-in-the-middle#189
Closed
timfish wants to merge 1 commit intonodejs:mainfrom
Closed
fix: Hook internal paths like require-in-the-middle#189timfish wants to merge 1 commit intonodejs:mainfrom
require-in-the-middle#189timfish wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
Author
|
Pain. The test failures are due to |
Member
Does this mean you can only patch what is explicitly exposed via |
Contributor
Author
|
Closing in favour of #194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require-in-the-middle#185@modelcontextprotocol/sdk#187import-in-the-middlediffers fromrequire-in-the-middlein that you can't patch library internals. Open Telemetry expects these libraries to behave in the same way so you can patch a library with the same hook configuration.import-in-the-middlewas not behaving as intended and documentedHookcallbacks being called a lot more, for all of a libraries internal files?