Skip to content

Make Zenmap code compatible with python3 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Varunram wants to merge 4 commits into from
Closed

Make Zenmap code compatible with python3 #665

Varunram wants to merge 4 commits into from

Conversation

@Varunram
Copy link

@Varunram Varunram commented Jan 25, 2017

Updated zenmap, ncat, ndiff to make it compatible with python3 with the help of 2to3.

@Varunram Varunram mentioned this pull request Jan 25, 2017
Closed
@Varunram
Copy link
Author

Varunram commented Jan 27, 2017

@dmiller-nmap The build fails due to travis not running python3 on zenmap, ncat and ndif. Otherwise, the code builds just fine.

@kstreitova
Copy link

kstreitova commented Jan 26, 2018

Hello,
Do you have any plans regarding this PR? I'm asking because many distributions (openSUSE [1], Fedora [2], Debian [3], Ubuntu [4], ...) are currently in the process of transition from Python 2 to Python 3 as a default. Because of that, I guess that it's a high time to switch to Python 3 for zenmap/ndiff/ncat too.

Thanks in advance for moving this forward!

[1] https://lists.opensuse.org/opensuse-factory/2017-06/msg00740.html
[2] https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3
[3] https://lists.debian.org/debian-python/2014/05/msg00037.html
[4] https://wiki.ubuntu.com/Python/3

@Varunram Varunram closed this Mar 12, 2018
@dmiller-nmap dmiller-nmap mentioned this pull request Apr 9, 2018
Closed
cclauss added a commit to cclauss/nmap that referenced this pull request Nov 7, 2022
@cclauss
GitHub Action to lint Python code
bf563c7 
Prove the Python syntax errors as discussed in
* nmap#91
* nmap#342
* nmap#624
* nmap#665
* nmap#666
* nmap#1176
* nmap#1484
* nmap#1807
* nmap#1972
* nmap#2088 
* nmap#2279
* nmap#2287
* nmap#2446
* nmap#2493
* nmap#2522
And many more...
@cclauss cclauss mentioned this pull request Nov 7, 2022
Closed
cclauss added a commit to cclauss/nmap that referenced this pull request Nov 7, 2022
@cclauss
GitHub Action to lint Python code
fb7a6e0 
Prove the Python syntax errors as discussed in
* nmap#91
* nmap#342
* nmap#624
* nmap#665
* nmap#666
* nmap#1176
* nmap#1484
* nmap#1807
* nmap#1972
* nmap#2088 
* nmap#2279
* nmap#2287
* nmap#2446
* nmap#2493
* nmap#2522
And many more...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Varunram @kstreitova