Fixed semantic for python3 #342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed semantics of except eg:- except E, N: to except E as N: For reference look up : https://www.python.org/dev/peps/pep-3110/#id22 Smit Patel <the1995captainh@gmail.com>
|
Hello @thebinarymutant, thanks for your PR. For now, we use python2 for Zenmap, and there are lots of files that would need to be updated in order to use python3. The advantage of python2 is that it is compatible with a lot of machines. So I would say this is a good PR but I don't know if we will switch to python3 now. I'll discuss that with my mentor @bonsaiviking and we'll keep you updated about the decision. Talk to you soon. Vincent |
|
Hi @thebinarymutant, I just made a commit on Nmap repository to apply your patch. You can find more detail on the commit page: d0774e7. |
tremblerz
pushed a commit
to tremblerz/nmap
that referenced
this pull request
Jul 20, 2016
tremblerz
pushed a commit
to tremblerz/nmap
that referenced
this pull request
Jul 21, 2016
batrick
pushed a commit
to batrick/nmap
that referenced
this pull request
Aug 2, 2016
git-svn-id: https://svn.nmap.org/nmap@35941 e0a8ed71-7df4-0310-8962-fdc924857419
cclauss
added a commit
to cclauss/nmap
that referenced
this pull request
Nov 7, 2022
cclauss
added a commit
to cclauss/nmap
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed semantics of except
eg:-
except E, N:
to
except E as N:
For reference look up : https://www.python.org/dev/peps/pep-3110/#id22
Smit Patel the1995captainh@gmail.com