Migrate to "watch" module for new file detection#9
Merged
Conversation
Contributor
Author
|
For an explanation of the logic within compileOnChange, check out the example in the watch module readme: |
Contributor
Author
|
One issue with this: there's a (possible) bug in the watch module that causes the filter regex to only be applied on the initial walk, but not to new files, so if you create a non-handlebars file in the watched directory, it will trigger a Just submitted a pull request to the watch module mikeal/watch#62 |
nicjansma
added a commit
that referenced
this pull request
Sep 13, 2014
Migrate to "watch" module for new file detection
Owner
|
This looks great, thanks paton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
I did some light testing with this and things seem to work as expected, and new files are successfully detected and watched.
@nicjansma If you'd like to go this route, we can merge this instead of #7.