Apply filter to newly created files#62
Merged
Merged
Conversation
mikeal
added a commit
that referenced
this pull request
Sep 11, 2014
Apply filter to newly created files
Contributor
Author
|
Thank you! If you could publish this to NPM that'd be much appreciated 👍 |
|
When will this be published? The Thanks |
Owner
|
published v0.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the filter function to new files.
Currently the filter is only applied on the initial walk. This causes filtered-out files to be watched after they're edited at least once.
For example, I have a filtered-out file called "built.js" with compiled javascript. When I fs.writeFile to built.js, it's detected as a new file and is watched from that point forward, thereby bypassing the filter function.
Thoughts on this?