Skip to content

feat: add overallScore and overallStatus QC columns to metadata.tsv#865

Closed
ivan-aksamentov wants to merge 1 commit intomasterfrom
feat/add-nextclade-qc-columns
Closed

feat: add overallScore and overallStatus QC columns to metadata.tsv#865
ivan-aksamentov wants to merge 1 commit intomasterfrom
feat/add-nextclade-qc-columns

Conversation

@ivan-aksamentov
Copy link
Copy Markdown
Member

Description of proposed changes

This adds the copying of the following columns from nextclade.tsv to metadata.tsv:

    "qc.overallScore": "QC_overall_score",
    "qc.overallStatus": "QC_overall_status",

Related issue(s)

Addresses the metadata portion of #861

See the symmetrical PR in ncov-igest: nextstrain/ncov-ingest#283

Testing

...

Release checklist

If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflow:

  • Determine the version number for the new release by incrementing the most recent release (e.g., "v2" from "v1").
  • Update docs/src/reference/change_log.md in this pull request to document these changes and the new version number.
  • After merging, create a new GitHub release with the new version number as the tag and release title.

If this pull request introduces new features, complete the following steps:

  • Update docs/src/reference/change_log.md in this pull request to document these changes by the date they were added.

Addresses the metadata portion of #861

See the symmetrical PR in ncov-igest: nextstrain/ncov-ingest#283

This adds the copying of the following columns from `nextclade.tsv` to `metadata.tsv`:

```
    "qc.overallScore": "QC_overall_score",
    "qc.overallStatus": "QC_overall_status",
```
ivan-aksamentov added a commit to nextstrain/ncov-ingest that referenced this pull request Feb 10, 2022
Addresses the metadata portion of nextstrain/ncov#861

See the symmetrical PR in ncov: nextstrain/ncov#865

This adds the copying of the following columns from `nextclade.tsv` to `metadata.tsv`:

```
    "qc.overallScore": "QC_overall_score",
    "qc.overallStatus": "QC_overall_status",
```
@ivan-aksamentov ivan-aksamentov requested a review from a team February 10, 2022 07:34
Copy link
Copy Markdown
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan-aksamentov
Copy link
Copy Markdown
Member Author

Closing this because #861 already includes the same changes

@ivan-aksamentov ivan-aksamentov deleted the feat/add-nextclade-qc-columns branch March 15, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants