Add deprecated aliases for config.schema package#6495
Merged
pditommaso merged 5 commits intomasterfrom Oct 20, 2025
Merged
Conversation
Member
Author
|
Weird, now is the new one the problem |
Closed
bentsherman
approved these changes
Oct 20, 2025
The config.schema package was recently renamed to config.spec in commit ef0d2d6. This change breaks backward compatibility for plugins that reference the old package names. This commit adds deprecated type aliases in the old package location to maintain backward compatibility while giving plugin developers time to migrate to the new package. The following deprecated classes were added: - ConfigScope (interface) - SchemaNode (annotation, now SpecNode) - ConfigOption (annotation) - ScopeName (annotation) - PlaceholderName (annotation) These aliases simply extend or mirror the new classes in nextflow.config.spec and are marked with @deprecated annotations pointing to the new locations. Fixes the NoClassDefFoundError: nextflow/config/schema/ConfigScope error that occurs when loading plugins compiled against older Nextflow versions. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
07511e2 to
8de208a
Compare
pditommaso
added a commit
that referenced
this pull request
Oct 21, 2025
…es (#6495) This commit addresses two issues stemming from the recent config.schema to config.spec package rename in #6485: 1. End-to-End Test Infrastructure Fix - Fixed test-e2e/run.sh to use the proper `installScratch` Makefile target - Changed from separate `make assemble` + `make install` to combined `make releaseInfo assemble installScratch` - The `installScratch` target (BUILD_PACK=1) is specifically designed for creating scratch container images used in the e2e test pipeline - This ensures the Nextflow runtime is correctly prepared for containerization and deployment to the Seqera Platform test environments 2. Backward Compatibility - Added deprecated type aliases in the old `nextflow.config.schema` package - Prevents `NoClassDefFoundError: nextflow/config/schema/ConfigScope` when loading plugins compiled against older Nextflow versions - Added deprecated classes: ConfigScope, ConfigOption, ScopeName, PlaceholderName - All deprecated classes delegate to their new counterparts in config.spec - Includes @deprecated annotations with Javadoc pointing to new locations The e2e test fixes ensure that the automated testing pipeline against Seqera Platform staging and production environments works correctly, while the compatibility aliases give plugin developers time to migrate to the new package structure. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the end-to-end test infrastructure and maintains backward compatibility after the recent package rename in #6485.
Main highlight: Fixed the e2e test build process to properly create scratch container images using the
installScratchtarget, resolving issues with the end-to-end test pipeline.Changes
End-to-End Test Fixes
make assemble+make installto combinedmake releaseInfo assemble installScratchinstallScratchtarget designed for creating scratch container imagesBackward Compatibility
Added deprecated type aliases in
nextflow.config.schemapackage to maintain compatibility with plugins compiled against the old package names (before the rename toconfig.specin #6485):ConfigScope(interface) - extends the newnextflow.config.spec.ConfigScopeConfigOption(annotation) - mirrors the new versionScopeName(annotation) - mirrors the new versionPlaceholderName(annotation) - mirrors the new versionAll deprecated classes include
@Deprecatedannotations with Javadoc pointing to the new locations.Test plan
installScratchtargetNoClassDefFoundErrorwhen loading plugins compiled against older Nextflow versionsRelated Issues
Fixes the error:
And resolves issues with the end-to-end test build process that prevented proper container image creation.
🤖 Generated with Claude Code