Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| const poolConnection = createPool({ | ||
| host: "localhost", | ||
| user: "root", |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
ndom91
approved these changes
Aug 8, 2023
Member
ndom91
left a comment
There was a problem hiding this comment.
Haven't tested it locally, but in general lgtm.
Some general feedback though, do we really need separate method implementations for each underlying db type (MySQL, postgres, etc.)?
Also these inline docs for TS hinting are getting a bit long 😅
balazsorban44
added a commit
that referenced
this pull request
Aug 8, 2023
Co-authored-by: Anthony Shew <anthonyshew@gmail.com>
3 tasks
|
@balazsorban44 why all functions from SQLiteDrizzleAdapter are not async/await like the pg/mysql ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing up @anthonyshew's PR #7165
Introducing a
drizzle-ormadapter!With
drizzle's increasing popularity, it's no surprise that there's a discussion for an adapter. This PR adds it.Notes
instanceofchecks to allow for multiple drizzle-orm instances to be used drizzle-team/drizzle-orm#283runBasicTestsutility to be able to provide some custom fixtures to workaround this. [mysql] Stop truncating timestamp milliseconds drizzle-team/drizzle-orm#668Closes #7165