chore: move prettier and eslint configs under package.json#7145
Merged
balazsorban44 merged 3 commits intonextauthjs:mainfrom Apr 4, 2023
SauravMaheshkar:main
Merged
chore: move prettier and eslint configs under package.json#7145balazsorban44 merged 3 commits intonextauthjs:mainfrom SauravMaheshkar:main
prettier and eslint configs under package.json#7145balazsorban44 merged 3 commits intonextauthjs:mainfrom
SauravMaheshkar:main
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@SauravMaheshkar is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
balazsorban44
approved these changes
Apr 4, 2023
prettier and eslint configuration under package.jsonprettier and eslint configs under package.json
Member
|
Thanks, @SauravMaheshkar! Do you know if https://github.com/nextauthjs/next-auth/blob/main/.prettierignore could also be moved for completeness? 🤔 This is picked up correctly by VSCode, right? I did merge it in good faith. If it breaks though, we might have to revert... |
Contributor
Author
|
Sadly there isn't. I really would've liked that though. I think we could raise a issue over at Prettier. Eslint supports, why not prettier 🤷🏽♂️ . |
balazsorban44
pushed a commit
that referenced
this pull request
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Changes proposed by this PR can be summarised as follows :-
.prettierrcunder theprettierkey inpackage.json. Source(prettier docs).eslintrc.jsunder theeslintConfigkey inpackage.json. Source(eslint docs).eslintignoreunder theeslintIgnorekey inpackage.json. Source(eslint docs)Doing so, would lead to a more minimal project structure without any functional change.