Skip to content

Update MjWarp dependency#1244

Merged
eric-heiden merged 1 commit into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/mjwarp-update
Dec 12, 2025
Merged

Update MjWarp dependency#1244
eric-heiden merged 1 commit into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/mjwarp-update

Conversation

@adenzler-nvidia

@adenzler-nvidia adenzler-nvidia commented Dec 11, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated dependency installation configuration to use a different commit version for a required package.

✏️ Tip: You can customize this high-level summary in your review settings.

@adenzler-nvidia
update versions
ad6c4ea 
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@coderabbitai

coderabbitai Bot commented Dec 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the mujoco_warp dependency git commit reference in asv.conf.json configuration file used for benchmarking environment setup. No modifications to control flow, error handling, or public API signatures.

Changes

Cohort / File(s) Change Summary
Dependency version update
asv.conf.json		 Updated git commit hash for mujoco_warp dependency installation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with a straightforward dependency commit update
  • No logic, control flow, or public API changes to evaluate

Possibly related PRs

Suggested reviewers

  • shi-eric
  • preist-nvidia
  • nvtw

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update MjWarp dependency' directly and clearly summarizes the main change in the pull request, which is updating the git commit for the mujoco_warp dependency in asv.conf.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56105c0 and ad6c4ea.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • asv.conf.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: nvlukasz
Repo: newton-physics/newton PR: 519
File: newton/_src/solvers/featherstone/kernels.py:75-75
Timestamp: 2025-08-12T18:04:06.577Z
Learning: The Newton physics framework requires nightly Warp builds, which means compatibility concerns with older stable Warp versions (like missing functions such as wp.spatial_adjoint) are not relevant for this project.

Learnt from: shi-eric
Repo: newton-physics/newton PR: 521
File: newton/examples/example_cloth_hanging.py:36-36
Timestamp: 2025-08-12T05:17:34.423Z
Learning: The Newton migration guide (docs/migration.rst) is specifically for documenting how to migrate existing warp.sim functionality to Newton equivalents. New Newton-only features that didn't exist in warp.sim do not need migration documentation.

Learnt from: shi-eric
Repo: newton-physics/newton PR: 660
File: pyproject.toml:28-28
Timestamp: 2025-08-27T23:33:32.527Z
Learning: In Python projects, it's normal and correct to have different warp-lang version specifications across files: pyproject.toml should specify minimum compatible versions using >= for flexibility, while specific environments like asv.conf.json can pin exact versions using == for reproducibility. These serve different purposes and should not be "aligned" to the same version.
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run GPU Benchmarks / Run GPU Benchmarks on AWS EC2
  • GitHub Check: Run GPU Tests / Run GPU Unit Tests on AWS EC2
🔇 Additional comments (1)
asv.conf.json (1)

22-22: Ensure mujoco_warp dependency is consistent across asv.conf.json and pyproject.toml.

The asv.conf.json pins mujoco_warp to commit 9b144f309bfe0e02b1c610530e59238c9b6a805f, but pyproject.toml (line 113) does not specify a commit hash—it only references the git repository without version pinning. This creates a discrepancy where:

  • asv benchmarks will use the pinned commit via direct pip install
  • Regular development/testing (via pyproject.toml) may resolve to a different version

Verify that the pinned commit is compatible with warp-lang==1.11.0.dev20251205 and mujoco==3.4.0.dev839962392, and consider whether pyproject.toml should also pin to this commit for consistency.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Dec 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@eric-heiden eric-heiden added this pull request to the merge queue Dec 12, 2025
Merged via the queue into newton-physics:main with commit 9eabbfc Dec 12, 2025
25 of 28 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jan 15, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jan 26, 2026
Merged
4 tasks
eric-heiden pushed a commit to eric-heiden/newton that referenced this pull request Jan 28, 2026
@adenzler-nvidia
Update MjWarp dependency (newton-physics#1244)
32a943b 
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@coderabbitai coderabbitai Bot mentioned this pull request Jan 29, 2026
Merged
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 13, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Feb 26, 2026
Merged
2 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Mar 11, 2026
Merged
3 tasks
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
@adenzler-nvidia
Update MjWarp dependency (newton-physics#1244)
9820ade 
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-heiden eric-heiden eric-heiden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adenzler-nvidia @eric-heiden