Skip to content

Update warp-lang to 1.11.0.dev20251115#1096

Merged
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/update-warp-lang
Nov 15, 2025
Merged

Update warp-lang to 1.11.0.dev20251115#1096
shi-eric merged 1 commit into
newton-physics:mainfrom
shi-eric:ershi/update-warp-lang

Conversation

@shi-eric

@shi-eric shi-eric commented Nov 15, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Contains a fix for .pch files ending up in the current working directory (temporarily before they're automatically deleted).

Newton Migration Guide

Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this PR.

  • The migration guide in docs/migration.rst is up-to date

Before your PR is "Ready for review"

  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Chores
    • Updated warp-lang prerelease version in configuration.

@shi-eric
Update warp-lang to 1.11.0.dev20251115
939ec17 
Signed-off-by: Eric Shi <ershi@nvidia.com>
@shi-eric shi-eric self-assigned this Nov 15, 2025
@coderabbitai

coderabbitai Bot commented Nov 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updates the warp-lang prerelease version in the ASV benchmark configuration from 1.11.0.dev20251111 to 1.11.0.dev20251115. This adjusts the development build used for performance testing to a newer prerelease build from 4 days later.

Changes

Cohort / File(s) Summary
ASV Configuration Update
asv.conf.json		 Updated warp-lang prerelease version in install_command from 1.11.0.dev20251111 to 1.11.0.dev20251115

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • eric-heiden
  • adenzler-nvidia

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately reflects the main change: updating warp-lang dependency to a newer prerelease version (1.11.0.dev20251115).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 323884b and 939ec17.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • asv.conf.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: shi-eric
Repo: newton-physics/newton PR: 521
File: newton/examples/example_cloth_hanging.py:36-36
Timestamp: 2025-08-12T05:17:34.423Z
Learning: The Newton migration guide (docs/migration.rst) is specifically for documenting how to migrate existing warp.sim functionality to Newton equivalents. New Newton-only features that didn't exist in warp.sim do not need migration documentation.

Learnt from: nvlukasz
Repo: newton-physics/newton PR: 519
File: newton/_src/solvers/featherstone/kernels.py:75-75
Timestamp: 2025-08-12T18:04:06.577Z
Learning: The Newton physics framework requires nightly Warp builds, which means compatibility concerns with older stable Warp versions (like missing functions such as wp.spatial_adjoint) are not relevant for this project.

Learnt from: shi-eric
Repo: newton-physics/newton PR: 660
File: pyproject.toml:28-28
Timestamp: 2025-08-27T23:33:32.527Z
Learning: In Python projects, it's normal and correct to have different warp-lang version specifications across files: pyproject.toml should specify minimum compatible versions using >= for flexibility, while specific environments like asv.conf.json can pin exact versions using == for reproducibility. These serve different purposes and should not be "aligned" to the same version.
📚 Learning: 2025-08-27T23:33:32.527Z 
Learnt from: shi-eric
Repo: newton-physics/newton PR: 660
File: pyproject.toml:28-28
Timestamp: 2025-08-27T23:33:32.527Z
Learning: In Python projects, it's normal and correct to have different warp-lang version specifications across files: pyproject.toml should specify minimum compatible versions using >= for flexibility, while specific environments like asv.conf.json can pin exact versions using == for reproducibility. These serve different purposes and should not be "aligned" to the same version.

Applied to files:

  • asv.conf.json
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run GPU Tests / Run GPU Unit Tests on AWS EC2
  • GitHub Check: Run GPU Benchmarks / Run GPU Benchmarks on AWS EC2
🔇 Additional comments (1)
asv.conf.json (1)

19-19: Verify version availability and address incomplete PR scope.

The version specification syntax is correct for ASV configuration. However, the specific dev version 1.11.0.dev20251115 does not exist on PyPI; the latest dev build found is 1.11.0.dev20251031. Since the pinned version is dated for today but not yet available, pip install will likely fail unless this version is released by NVIDIA before merge.

Additionally, the different version specifications across files are intentional and correct—asv.conf.json appropriately pins exact versions for reproducibility with ==, while pyproject.toml specifies minimum versions using >= for flexibility. These serve different purposes and should remain distinct.

However, the PR remains incomplete:

  • The PR description mentions a fix preventing .pch files from being left in the current working directory—this fix is not visible in the codebase.
  • The pre-review checklist items (tests, documentation, pre-commit checks, migration guide update) are all unchecked.

Before approval, verify:

  1. Whether 1.11.0.dev20251115 is scheduled for release today or if this is a placeholder version.
  2. The complete scope of changes, including where the .pch file fix is implemented.
  3. The PR is ready for review and not in draft status.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shi-eric shi-eric enabled auto-merge November 15, 2025 22:06
@shi-eric shi-eric requested a review from eric-heiden November 15, 2025 22:06
@codecov

codecov Bot commented Nov 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

eric-heiden
eric-heiden approved these changes Nov 15, 2025
View reviewed changes

@eric-heiden eric-heiden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was wondering why those pch files appeared in the current working directory. :)

@shi-eric shi-eric added this pull request to the merge queue Nov 15, 2025
Merged via the queue into newton-physics:main with commit c152821 Nov 15, 2025
20 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Dec 8, 2025
Merged
3 tasks
@shi-eric shi-eric deleted the ershi/update-warp-lang branch December 19, 2025 16:17
@coderabbitai coderabbitai Bot mentioned this pull request Jan 6, 2026
Merged
eric-heiden pushed a commit to eric-heiden/newton that referenced this pull request Jan 28, 2026
@shi-eric
Update warp-lang to 1.11.0.dev20251115 (newton-physics#1096)
3ad7527 
Signed-off-by: Eric Shi <ershi@nvidia.com>
This was referenced Jan 28, 2026
Merged
Merged
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
@shi-eric
Update warp-lang to 1.11.0.dev20251115 (newton-physics#1096)
bbd320e 
Signed-off-by: Eric Shi <ershi@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-heiden eric-heiden eric-heiden approved these changes

Assignees

@shi-eric shi-eric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shi-eric @eric-heiden