Skip to content

Reviewed all assert for necessary side effects.#306

Merged
nrnhines merged 1 commit into
masterfrom
assert2nrn_assert
Nov 7, 2019
Merged

Reviewed all assert for necessary side effects.#306
nrnhines merged 1 commit into
masterfrom
assert2nrn_assert

Conversation

@nrnhines

@nrnhines nrnhines commented Nov 7, 2019

Copy link
Copy Markdown
Member

30 converted from assert to nrn_assert. So work properly with NDEBUG
defined.

30 converted from assert to nrn_assert. So work properly with NDEBUG
defined.
@nrnhines nrnhines merged commit b21f32c into master Nov 7, 2019
@nrnhines nrnhines deleted the assert2nrn_assert branch November 7, 2019 19:53
nrnhines added a commit that referenced this pull request Nov 7, 2019
30 converted from assert to nrn_assert. So work properly with NDEBUG
defined.
ohm314 pushed a commit that referenced this pull request Nov 8, 2019
30 converted from assert to nrn_assert. So work properly with NDEBUG
defined.
nrnhines pushed a commit that referenced this pull request Nov 18, 2019
* An initial commit to get code documentation into NEURON

* Added cmake target and generate docs inside build dir

* A more reasonable logo

* Added some cmake instructions into README.md

* Reviewed all assert for necessary side effects. (#306) (#307)

30 converted from assert to nrn_assert. So work properly with NDEBUG
defined.

* Just minor cleanup

formatting in doxygen still doens't look great, but we can iron this out
later

* Added building doxygen in travis and deploying docs

* make doxygen only

* travis.yml fix

* fixed travis script to build doc for one job

* Added documentation preperation

* Reverted jobs changes for testing

* Small fix in README.md cmake options

* Added cmake option NRN_BUILD_DOC and selectively build doc in travis

* Reverted make install in travis

* Remove build option for doxygen

* Added some more groups

* update travis for docs

* Revert travis change

* Small fix to travis plan

* Small fix in if statement to build doc
pramodk added a commit that referenced this pull request Dec 2, 2019
* digittoint not standard on linux
* Use neuron.test() instead of rxd specific test.
* update submodules : iv as well as coreneuron (#302)
* Array for spike compression may not be allocated in some circumstances. (#293)
* Remove legacy options for purify and mpitrace library of bg-q (#296)
* Avoid bash warning/error for empty if block (#298)
* add back the run_all.py travis_cl test
* Reviewed all assert for necessary side effects. (#306) (#307)
  30 converted from assert to nrn_assert. So work properly with NDEBUG
  defined.

Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
Co-authored-by: Michael Hines <michael.hines@yale.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant