Avoid bash warning/error for empty if block#298
Merged
Conversation
nrnhines
reviewed
Oct 30, 2019
| @NRNMECH_DLL_STYLE_TRUE@@MAC_DARWIN_TRUE@if false ; then | ||
| @NRNMECH_DLL_STYLE_TRUE@@MAC_DARWIN_FALSE@if false ; then | ||
| @NRNMECH_DLL_STYLE_FALSE@if false ; then | ||
| : #for empty if block |
Member
There was a problem hiding this comment.
I would replace the ':' with false
Closed
pramodk
added a commit
that referenced
this pull request
Dec 2, 2019
* digittoint not standard on linux * Use neuron.test() instead of rxd specific test. * update submodules : iv as well as coreneuron (#302) * Array for spike compression may not be allocated in some circumstances. (#293) * Remove legacy options for purify and mpitrace library of bg-q (#296) * Avoid bash warning/error for empty if block (#298) * add back the run_all.py travis_cl test * Reviewed all assert for necessary side effects. (#306) (#307) 30 converted from assert to nrn_assert. So work properly with NDEBUG defined. Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch> Co-authored-by: Michael Hines <michael.hines@yale.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #296, we get following warning (syntax error) from bash:
This is because the resultant section in nrnivmodl becomes:
and above empty
if blockis not syntax error.In this PR I added empty bash statement using
:Thanks to @jorblancoa for pointing this out!