Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (17bd2c8) to head (76d3d1d).
Report is 246 commits behind head on master.

@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
+ Coverage   66.23%   66.26%   +0.02%     
==========================================
  Files         559      557       -2     
  Lines      104008   103950      -58     
==========================================
- Hits        68890    68881       -9     
+ Misses      35118    35069      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

✔️ af57bd1 -> Azure artifacts URL

✔️ a5507cc -> Azure artifacts URL

@alkino : I was reviewing Michael's comment during last meeting (recording here @ time 17:20). He confirmed removal of 1) Isaac64 2) ACG 3) MLCG.

So I was thinking the steps could be following:

• A PR to remove 1) Isaac64 2) ACG 3) MLCG
  • launch the modelDB CI
  • hopefully there won't be many neuron tests or ModelDB models CI failures as these are not used much (?)
  • if any tests are using those then fix the tests to use Random123.
  • Michael will look into ModelDB CI failures, convert them to Random123 and validate results
• Along with the above PR, create a PR to release/8.2 branch adding warning if user try to instantiation any of the above 3
• Create separate PR for updating MCellRan4 to use Random123 underneath (i.e. we keep API)
  • same CI checks as above.
  • As MCellRan4 might have been used at more places, there might be a bit more work. But Michael has offered help to validate & convert models with Random123.

So considering the above, I am wondering if it is possible to split the removal of the above 3 RNs in one PR and MCellRan4 into another one. My "hope" is that the removal of the above 3 should be straightforward / less or no CI failures and hence can be merged faster.

✔️ efbf7c5 -> Azure artifacts URL

NEURON ModelDB CI: launching for efbf7c5 via its drop url

✔️ f48accb -> Azure artifacts URL

Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

✔️ 76d3d1d -> Azure artifacts URL

Logfiles from GitLab pipeline #192359 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

Replaced by #3188, #3189 and #3190