Skip to content

Replace Isaac64 by Random123#3188

Merged
nrnhines merged 2 commits into
masterfrom
cornu/isaac64
Nov 9, 2024
Merged

Replace Isaac64 by Random123#3188
nrnhines merged 2 commits into
masterfrom
cornu/isaac64

Conversation

@alkino

@alkino alkino commented Nov 9, 2024

Copy link
Copy Markdown
Member

This has already been accepted by @nrnhines a long time ago (#2674).
This is only a split of the old PR.

@azure-pipelines

Copy link
Copy Markdown

✔️ da8340b -> Azure artifacts URL

@codecov

codecov Bot commented Nov 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (a5d0015) to head (c55f95b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrniv/multisend_setup.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3188   +/-   ##
=======================================
  Coverage   67.05%   67.06%           
=======================================
  Files         571      570    -1     
  Lines      111256   111232   -24     
=======================================
- Hits        74604    74599    -5     
+ Misses      36652    36633   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@nrnhines nrnhines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to add or augment a multisend test that covers the line in multisend_setup.cpp

Comment thread src/nrniv/multisend_setup.cpp
@nrnhines nrnhines enabled auto-merge (squash) November 9, 2024 13:59
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2024

Copy link
Copy Markdown

@azure-pipelines

Copy link
Copy Markdown

✔️ c55f95b -> Azure artifacts URL

@nrnhines nrnhines merged commit 625f3d1 into master Nov 9, 2024
@nrnhines nrnhines deleted the cornu/isaac64 branch November 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants