Skip to content

Replace ACG by Random123#3190

Merged
nrnhines merged 3 commits into
masterfrom
cornu/acg
Nov 11, 2024
Merged

Replace ACG by Random123#3190
nrnhines merged 3 commits into
masterfrom
cornu/acg

Conversation

@alkino

@alkino alkino commented Nov 9, 2024

Copy link
Copy Markdown
Member

The last one.

@alkino alkino requested a review from nrnhines November 9, 2024 14:57
@azure-pipelines

Copy link
Copy Markdown

✔️ 0678ba4 -> Azure artifacts URL

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2024

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (625f3d1) to head (75aafb5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3190   +/-   ##
=======================================
  Coverage   67.06%   67.07%           
=======================================
  Files         570      569    -1     
  Lines      111232   111204   -28     
=======================================
- Hits        74599    74590    -9     
+ Misses      36633    36614   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azure-pipelines

Copy link
Copy Markdown

✔️ 75aafb5 -> Azure artifacts URL

@alkino alkino added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Nov 10, 2024
@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Nov 10, 2024
@github-actions

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for 75aafb5 via its drop url

@alkino

alkino commented Nov 11, 2024

Copy link
Copy Markdown
Member Author

There is differences in nrn-modeldb that we shoud analyze.

@nrnhines

nrnhines commented Nov 11, 2024

Copy link
Copy Markdown
Member

There is differences in nrn-modeldb that we shoud analyze.

I agree. It's a bit time consuming and I have little doubt it's due to different random values. But it should be checked. I will do that.

I verified that the differences for the 15 models were due to the change in default randomness. Model 18502 was particularly different but was still due to randomness and much more similar results for the graphs were obtained with
Random123_globalindex(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants