Pin cython to < 3. Workaround for #2430#2433
Merged
Merged
Conversation
alkino
reviewed
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 60.19% 60.20%
=======================================
Files 627 627
Lines 121091 121090 -1
=======================================
+ Hits 72895 72905 +10
+ Misses 48196 48185 -11 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
|
✔️ ce57196 -> Azure artifacts URL |
alkino
approved these changes
Jul 18, 2023
pramodk
requested changes
Jul 18, 2023
pramodk
left a comment
Member
There was a problem hiding this comment.
LGTM
- Could we also update our CMake logic so that it errors if CMake >= 3.0? This way it would be a bit easy for users.
- Updating
install_instructions.mdwould be nice!
Member
|
Oops! Missed by 5 seconds, @alexsavulescu ! :d |
Member
Author
|
Currently opening a issue |
Member
Author
We already have checks for requirements. Install instructions are appropriate I believe |
Member
|
I didn't check myself but I was clarifying if our CMake configure steps fail if we detect Cython >= 3.0. |
Collaborator
Member
Author
I thought it did but it does not |
Closed
Merged
nrnhines
pushed a commit
that referenced
this pull request
Sep 2, 2023
nrnhines
pushed a commit
that referenced
this pull request
Sep 2, 2023
nrnhines
pushed a commit
that referenced
this pull request
Sep 6, 2023
nrnhines
added a commit
that referenced
this pull request
Sep 13, 2023
* Fix MacOS linux wheel backspace by upgrading ncurses-6.2 to 6.4 (#2484) * Fix Windows and Mac crash on multiline HOC statements input from terminal. (#2258) * Windows 11 fix for hoc icon. (#2279) * test using nrniv -isatty Mac and Windows have trouble with the test. * Update the documentation for better clarity * Pin cython to < 3. Workaround for #2430 (#2433) Cherry picked from 116a541. Eliminate non cython<3 changes from cherrypick * Bump VERSION to 8.2.3 in CMakeLists.txt * deal with .inputrc if missing on windows * Backport changes from github docs workflow * Disable shallow clone with the option * use docs/domains/hocdomain.py from master for latest sphinx compatibility * downgrade black version (30 python files have trivial format differences) * Picked the "final:" fragment out of the master version. Fixes "Final CI Expected --- Waiting for status to be reported" --------- Co-authored-by: Pramod S Kumbhar <pramod.s.kumbhar@gmail.com> Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
pramodk
pushed a commit
that referenced
this pull request
Jan 11, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.