Fix Windows and Mac crash on multiline HOC statements input from terminal.#2258
Merged
Conversation
Relevant to Mac and MINGW.
…ents." This reverts commit 634497c.
Note: if, in a multline statement, the gui tries to execute a statement, an error is generated: hoc_run1: caught exception: hoc_execerror: Cannot reenter parser. Maybe you were in the middle of a direct command.
Codecov Report
@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
+ Coverage 56.87% 56.89% +0.02%
==========================================
Files 620 620
Lines 121562 121562
==========================================
+ Hits 69140 69165 +25
+ Misses 52422 52397 -25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ 53ce9c5 -> Azure artifacts URL |
Collaborator
Contributor
Contributor
|
✔️ 00f097a -> Azure artifacts URL |
Collaborator
|
✔️ f3b2f7f -> Azure artifacts URL |
Collaborator
alexsavulescu
approved these changes
Mar 10, 2023
nrnhines
added a commit
that referenced
this pull request
Sep 2, 2023
…inal. (#2258) * MINGW: if in yyparse, rl_getc_function should = rl_getc * Mac: rl_getc_function is always getc_hook. Allow multiline statements. Note: if, in a multline statement, the gui tries to execute a statement, an error is generated: hoc_run1: caught exception: hoc_execerror: Cannot reenter parser. Maybe you were in the middle of a direct command. * test using nrniv -isatty Mac and Windows have trouble with the test.
nrnhines
added a commit
that referenced
this pull request
Sep 6, 2023
…inal. (#2258) * MINGW: if in yyparse, rl_getc_function should = rl_getc * Mac: rl_getc_function is always getc_hook. Allow multiline statements. Note: if, in a multline statement, the gui tries to execute a statement, an error is generated: hoc_run1: caught exception: hoc_execerror: Cannot reenter parser. Maybe you were in the middle of a direct command. * test using nrniv -isatty Mac and Windows have trouble with the test.
nrnhines
added a commit
that referenced
this pull request
Sep 13, 2023
* Fix MacOS linux wheel backspace by upgrading ncurses-6.2 to 6.4 (#2484) * Fix Windows and Mac crash on multiline HOC statements input from terminal. (#2258) * Windows 11 fix for hoc icon. (#2279) * test using nrniv -isatty Mac and Windows have trouble with the test. * Update the documentation for better clarity * Pin cython to < 3. Workaround for #2430 (#2433) Cherry picked from 116a541. Eliminate non cython<3 changes from cherrypick * Bump VERSION to 8.2.3 in CMakeLists.txt * deal with .inputrc if missing on windows * Backport changes from github docs workflow * Disable shallow clone with the option * use docs/domains/hocdomain.py from master for latest sphinx compatibility * downgrade black version (30 python files have trivial format differences) * Picked the "final:" fragment out of the master version. Fixes "Final CI Expected --- Waiting for status to be reported" --------- Co-authored-by: Pramod S Kumbhar <pramod.s.kumbhar@gmail.com> Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2257
Windows and Mac now act like linux for multiline HOC statements
Note that on linux, the GUI is locked out during multiline statement input. On the mac an error is generated