fix MUSIC setup.py and add coverage#2209
Closed
alexsavulescu wants to merge 2 commits into
Closed
Conversation
Merged
edb9128 to
f3a600c
Compare
Collaborator
5ec104f to
390179c
Compare
|
✔️ 390179c -> Azure artifacts URL |
d6906c5 to
a15d446
Compare
add coverage setup
a15d446 to
06ce9c7
Compare
|
✔️ 06ce9c7 -> Azure artifacts URL |
Member
Author
|
Looks to me MUSIC implementation is not complete? Not sure how #2091 plays in here .. |
Collaborator
Collaborator
Collaborator
1bb277e to
d5df041
Compare
Member
Author
|
Merged into #2092 |
Collaborator
alexsavulescu
added a commit
that referenced
this pull request
Feb 8, 2023
alexsavulescu
added a commit
that referenced
this pull request
Feb 8, 2023
* remove distutils usage * follow PEP632 * add own `strtobool` * use new_compiler from setuptools build_ext for now * `python setup.py install` is deprecated (and problematic see -> #1605) * update NRN_ENABLE_MODULE_INSTALL logic * modules installed in default location * drop `SETUPTOOLS_USE_DISTUTILS=stdlib` * MUSIC + MPI multiple includes fix from #2209 * MUSIC CI basic tests
nrnhines
pushed a commit
that referenced
this pull request
Sep 6, 2023
* remove distutils usage * follow PEP632 * add own `strtobool` * use new_compiler from setuptools build_ext for now * `python setup.py install` is deprecated (and problematic see -> #1605) * update NRN_ENABLE_MODULE_INSTALL logic * modules installed in default location * drop `SETUPTOOLS_USE_DISTUTILS=stdlib` * MUSIC + MPI multiple includes fix from #2209 * MUSIC CI basic tests
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
* remove distutils usage * follow PEP632 * add own `strtobool` * use new_compiler from setuptools build_ext for now * `python setup.py install` is deprecated (and problematic see -> #1605) * update NRN_ENABLE_MODULE_INSTALL logic * modules installed in default location * drop `SETUPTOOLS_USE_DISTUTILS=stdlib` * MUSIC + MPI multiple includes fix from #2209 * MUSIC CI basic tests
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
* remove distutils usage * follow PEP632 * add own `strtobool` * use new_compiler from setuptools build_ext for now * `python setup.py install` is deprecated (and problematic see -> #1605) * update NRN_ENABLE_MODULE_INSTALL logic * modules installed in default location * drop `SETUPTOOLS_USE_DISTUTILS=stdlib` * MUSIC + MPI multiple includes fix from #2209 * MUSIC CI basic tests
JCGoran
pushed a commit
that referenced
this pull request
Jan 16, 2024
* remove distutils usage * follow PEP632 * add own `strtobool` * use new_compiler from setuptools build_ext for now * `python setup.py install` is deprecated (and problematic see -> #1605) * update NRN_ENABLE_MODULE_INSTALL logic * modules installed in default location * drop `SETUPTOOLS_USE_DISTUTILS=stdlib` * MUSIC + MPI multiple includes fix from #2209 * MUSIC CI basic tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.