Skip to content

remove distutils usage#2193

Merged
alexsavulescu merged 9 commits into
masterfrom
bye-distutils
Feb 8, 2023
Merged

remove distutils usage#2193
alexsavulescu merged 9 commits into
masterfrom
bye-distutils

Conversation

@alexsavulescu

@alexsavulescu alexsavulescu commented Jan 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

remove disutils usage

@alexsavulescu alexsavulescu marked this pull request as draft January 25, 2023 13:43
matz-e
matz-e reviewed Jan 25, 2023
View reviewed changes

@matz-e matz-e left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

Comment thread setup.py Outdated
alexsavulescu added a commit that referenced this pull request Jan 25, 2023
@alexsavulescu
drop python 3.7 support for master -> upcoming 9.0.0
d5dcab3 
* EOL (only security fixes mode until 06-2023, no bugfixes anymore)
* reduce CI time and avoid adding more technical debt (i.e. #2123 #2193)
@alexsavulescu alexsavulescu mentioned this pull request Jan 25, 2023
Merged
@bbpbuildbot

bbpbuildbot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #97416 (:no_entry:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu mentioned this pull request Jan 25, 2023
Closed
3 tasks
alexsavulescu added a commit that referenced this pull request Jan 25, 2023
@alexsavulescu
drop python 3.7 support for master -> upcoming 9.0.0 (#2194)
7d905a3 
* EOL (only security fixes mode until 06-2023, no bugfixes anymore)
* reduce CI time and avoid adding more technical debt (i.e. #2123 #2193)
@bbpbuildbot

bbpbuildbot commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #97485 (:no_entry:) have been uploaded here!

Status and direct links:

@olupton olupton mentioned this pull request Jan 26, 2023
Merged
3 tasks
@codecov-commenter

codecov-commenter commented Jan 27, 2023 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2193 (824c765) into master (c89d377) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #2193   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files         617      618    +1     
  Lines      124106   124113    +7     
=======================================
+ Hits        69812    69818    +6     
- Misses      54294    54295    +1
Impacted Files Coverage Δ
share/lib/python/neuron/tests/utils/strtobool.py 85.71% <85.71%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

bbpbuildbot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #98125 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #98465 (:no_entry:) have been uploaded here!

Status and direct links:

@alexsavulescu
* remove distutils usage
37f2260 
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * drop NRN_ENABLE_MODULE_INSTALL
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
@bbpbuildbot

bbpbuildbot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #99317 (:no_entry:) have been uploaded here!

Status and direct links:

@azure-pipelines

azure-pipelines Bot commented Feb 1, 2023

Copy link
Copy Markdown

✔️ 37f2260 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Feb 1, 2023

Copy link
Copy Markdown

✔️ f5758a8 -> Azure artifacts URL

@alexsavulescu alexsavulescu added the nrn-modeldb-ci-nightly Launch external ModelDB CI label Feb 1, 2023
@github-actions github-actions Bot removed the nrn-modeldb-ci-nightly Launch external ModelDB CI label Feb 1, 2023
@github-actions

github-actions Bot commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: launching for f5758a8 via its drop url

@bbpbuildbot

bbpbuildbot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #99365 (:white_check_mark:) have been uploaded here!

Status and direct links:

@github-actions

github-actions Bot commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

NEURON ModelDB CI: f5758a8 -> download reports from here

@azure-pipelines

azure-pipelines Bot commented Feb 1, 2023

Copy link
Copy Markdown

✔️ a01ee59 -> Azure artifacts URL

@bbpbuildbot

bbpbuildbot commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #99379 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu requested a review from matz-e February 2, 2023 08:53
@alexsavulescu alexsavulescu marked this pull request as ready for review February 2, 2023 08:53
@bbpbuildbot

bbpbuildbot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #100145 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu mentioned this pull request Feb 8, 2023
Merged
@alexsavulescu alexsavulescu requested review from nrnhines and removed request for nrnhines February 8, 2023 09:12
@azure-pipelines

azure-pipelines Bot commented Feb 8, 2023

Copy link
Copy Markdown

✔️ 51b9d06 -> Azure artifacts URL

@alexsavulescu alexsavulescu force-pushed the bye-distutils branch 2 times, most recently from 44ce8a9 to ae3ed1e Compare February 8, 2023 11:03
@azure-pipelines

azure-pipelines Bot commented Feb 8, 2023

Copy link
Copy Markdown

✔️ ae3ed1e -> Azure artifacts URL

@alexsavulescu alexsavulescu force-pushed the bye-distutils branch 4 times, most recently from fbeaad5 to df55cb2 Compare February 8, 2023 12:18
@azure-pipelines

azure-pipelines Bot commented Feb 8, 2023

Copy link
Copy Markdown

✔️ 824c765 -> Azure artifacts URL

nrnhines
nrnhines approved these changes Feb 8, 2023
View reviewed changes

@nrnhines nrnhines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Will be happy to no longer see distutils messages:)

Comment thread src/neuronmusic/CMakeLists.txt
@bbpbuildbot

bbpbuildbot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #100696 (:no_entry:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu merged commit 799a104 into master Feb 8, 2023
nrnhines pushed a commit that referenced this pull request Sep 6, 2023
@alexsavulescu @nrnhines
drop python 3.7 support for master -> upcoming 9.0.0 (#2194)
85f36b0 
* EOL (only security fixes mode until 06-2023, no bugfixes anymore)
* reduce CI time and avoid adding more technical debt (i.e. #2123 #2193)
nrnhines pushed a commit that referenced this pull request Sep 6, 2023
@alexsavulescu @nrnhines
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
c72e0a3 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
@iomaganaris iomaganaris mentioned this pull request Jan 8, 2024
Merged
2 tasks
JCGoran pushed a commit that referenced this pull request Jan 12, 2024
@alexsavulescu
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
8301269 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
JCGoran pushed a commit that referenced this pull request Jan 12, 2024
@alexsavulescu
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
043a2c2 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
JCGoran pushed a commit that referenced this pull request Jan 16, 2024
@alexsavulescu @JCGoran
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
75599aa 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
@heerener heerener mentioned this pull request Feb 6, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matz-e matz-e matz-e approved these changes
@nrnhines nrnhines nrnhines approved these changes
@pramodk pramodk Awaiting requested review from pramodk
@ohm314 ohm314 Awaiting requested review from ohm314

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexsavulescu @bbpbuildbot @codecov-commenter @pramodk @matz-e @nrnhines