Add Python3.11 to the release/8.2 Mac pkg distribution#2073
Merged
Conversation
* Workaround for: #1605 See: * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html * https://setuptools.pypa.io/en/latest/history.html#id228 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> cherry-pick from master 962533e to allow build with Python3.11
|
✔️ e41ab1d -> Azure artifacts URL |
alexsavulescu
approved these changes
Nov 9, 2022
alexsavulescu
left a comment
Member
There was a problem hiding this comment.
LGTM. I guess the failures we see have been fixed in master
Member
Author
I'll cherry pick the fixes from master into release/8.2 |
Codecov Report
@@ Coverage Diff @@
## release/8.2 #2073 +/- ##
============================================
Coverage 47.35% 47.35%
============================================
Files 543 543
Lines 112688 112688
============================================
Hits 53367 53367
Misses 59321 59321
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ e5c6173 -> Azure artifacts URL |
alexsavulescu
added a commit
that referenced
this pull request
Dec 15, 2022
* SETUPTOOLS_USE_DISTUTILS=stdlib (#1924) * Workaround for: #1605 See: * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html * https://setuptools.pypa.io/en/latest/history.html#id228 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> cherry-pick from master 962533e to allow build with Python3.11 * check for NULL. (already fixed in master 962533e) * Add python3.11 to pkg build. Some hints for the build script. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a segfault due to not checking that a pointer is NULL.
If not tagged the distribution identifier will be something like