SETUPTOOLS_USE_DISTUTILS=stdlib#1924
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
- Coverage 47.24% 47.20% -0.04%
==========================================
Files 543 543
Lines 112941 112941
==========================================
- Hits 53354 53309 -45
- Misses 59587 59632 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ d6c92b7 -> Azure artifacts URL |
|
✔️ 2544fa8 -> Azure artifacts URL |
olupton
reviewed
Jul 19, 2022
|
✔️ 55b7263 -> Azure artifacts URL |
nrnhines
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Workaround for: #1605 See: * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html * https://setuptools.pypa.io/en/latest/history.html#id228 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> cherry-pick from master 962533e to allow build with Python3.11
nrnhines
added a commit
that referenced
this pull request
Nov 9, 2022
* SETUPTOOLS_USE_DISTUTILS=stdlib (#1924) * Workaround for: #1605 See: * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html * https://setuptools.pypa.io/en/latest/history.html#id228 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> cherry-pick from master 962533e to allow build with Python3.11 * check for NULL. (already fixed in master 962533e) * Add python3.11 to pkg build. Some hints for the build script. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
pramodk
added a commit
that referenced
this pull request
Nov 23, 2022
* removal of distutils.log.Log from setuptools breaks building packages like numpy. See pypa/setuptools#3693 * we have used SETUPTOOLS_USE_DISTUTILS alternative already in #1924 * update circle-ci and azure pipelines similarly
1 task
pramodk
added a commit
that referenced
this pull request
Nov 23, 2022
* removal of distutils.log.Log from setuptools breaks building packages like numpy. See pypa/setuptools#3693 * we have used SETUPTOOLS_USE_DISTUTILS alternative already in #1924 * update circle-ci and azure pipelines similarly
alexsavulescu
added a commit
that referenced
this pull request
Dec 15, 2022
* SETUPTOOLS_USE_DISTUTILS=stdlib (#1924) * Workaround for: #1605 See: * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html * https://setuptools.pypa.io/en/latest/history.html#id228 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> cherry-pick from master 962533e to allow build with Python3.11 * check for NULL. (already fixed in master 962533e) * Add python3.11 to pkg build. Some hints for the build script. Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1605 #1921
Still in need to tackle
distutilsdeprecation though.