Skip to content

Remove never implemented token TERMINAL, SECTION#1974

Merged
pramodk merged 1 commit into
masterfrom
remove_unused_token
Sep 29, 2022
Merged

Remove never implemented token TERMINAL, SECTION#1974
pramodk merged 1 commit into
masterfrom
remove_unused_token

Conversation

@alkino

@alkino alkino commented Sep 6, 2022 •
edited by pramodk
Loading

Copy link
Copy Markdown
Member

@alkino alkino requested review from nrnhines and pramodk September 6, 2022 15:45
@alkino alkino force-pushed the remove_unused_token branch from 5f351dd to 942db26 Compare September 6, 2022 16:09
@alkino alkino mentioned this pull request Sep 6, 2022
Merged
@azure-pipelines

azure-pipelines Bot commented Sep 6, 2022

Copy link
Copy Markdown

✔️ 942db2669bae2424c768ca5a099f7feb9d0a5a0e -> Azure artifacts URL

@alkino alkino force-pushed the remove_unused_token branch from 942db26 to ef9c9b5 Compare September 9, 2022 07:37
@alkino alkino changed the title Remove never implemented token TERMINAL, PUTQ/GETQ, SECTION Remove never implemented token TERMINAL, SECTION Sep 9, 2022
@alkino alkino changed the base branch from master to remove_getq_putq September 9, 2022 07:37
@azure-pipelines

azure-pipelines Bot commented Sep 9, 2022

Copy link
Copy Markdown

✔️ ef9c9b5fda6ea7f359d20c5a2348375e5b96c9cd -> Azure artifacts URL

Base automatically changed from remove_getq_putq to master September 9, 2022 08:25
@alkino alkino force-pushed the remove_unused_token branch from ef9c9b5 to b9a9138 Compare September 9, 2022 08:37
@azure-pipelines

azure-pipelines Bot commented Sep 9, 2022

Copy link
Copy Markdown

✔️ b9a9138fb24e436ecdfd99cac4676c6197185fd1 -> Azure artifacts URL

@alkino @pramodk
Remove never implemented token TERMINAL, SECTION
58fb5ea 
Those token have never been implemented so we can remove it safely
@pramodk pramodk force-pushed the remove_unused_token branch from b9a9138 to 58fb5ea Compare September 29, 2022 04:07
pramodk
pramodk approved these changes Sep 29, 2022
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 69c418b into master Sep 29, 2022
@pramodk pramodk deleted the remove_unused_token branch September 29, 2022 04:30
@azure-pipelines

azure-pipelines Bot commented Sep 29, 2022

Copy link
Copy Markdown

✔️ 58fb5ea -> Azure artifacts URL

pramodk pushed a commit to BlueBrain/nmodl that referenced this pull request Sep 29, 2022
@alkino
Remove token that have never be implemented in nrn: STEPPED / TERMINA…
7b20833 
…L / PLOT / SENS / SECTION (#926)

* Following constructs are no longer relevant in the NEURON context:
   STEPPED / TERMINAL / PLOT / SENS / SECTION
* See discussion in neuronsimulator/nrn#1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pramodk pramodk pramodk approved these changes
@nrnhines nrnhines Awaiting requested review from nrnhines

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alkino @pramodk