Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Remove token that have never be implemented in nrn: STEPPED / TERMINAL / PLOT / SENS / SECTION#926

Merged
pramodk merged 5 commits into
masterfrom
remove_unused_token
Sep 29, 2022
Merged

Remove token that have never be implemented in nrn: STEPPED / TERMINAL / PLOT / SENS / SECTION#926
pramodk merged 5 commits into
masterfrom
remove_unused_token

Conversation

@alkino

@alkino alkino commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Those TOKENS are STEPPED / TERMINAL / PLOT / SENS / SECTION

Following neuronsimulator/nrn#1974

@alkino alkino force-pushed the remove_unused_token branch from ba9f9ed to 2402472 Compare September 6, 2022 16:14
@bbpbuildbot

bbpbuildbot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #73360 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #73451 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino force-pushed the remove_unused_token branch from 90d273c to 9d95c1c Compare September 9, 2022 08:39
@alkino alkino changed the base branch from master to remove_getq_putq September 9, 2022 08:39
@bbpbuildbot

bbpbuildbot commented Sep 9, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #73681 (:white_check_mark:) have been uploaded here!

Status and direct links:

Base automatically changed from remove_getq_putq to master September 9, 2022 10:36
@alkino alkino force-pushed the remove_unused_token branch from 9d95c1c to 116357b Compare September 12, 2022 06:41
@codecov-commenter

codecov-commenter commented Sep 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #926 (116357b) into master (af7c772) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   62.13%   62.42%   +0.29%     
==========================================
  Files         194      194              
  Lines       28337    28049     -288     
==========================================
- Hits        17606    17509      -97     
+ Misses      10731    10540     -191
Impacted Files Coverage Δ
src/codegen/codegen_compatibility_visitor.cpp 44.44% <ø> (ø)
src/language/templates/pybind/pysymtab.cpp 95.84% <ø> (-0.07%) ⬇️
src/lexer/nmodl_utils.cpp 96.55% <ø> (-0.06%) ⬇️
src/lexer/token_mapping.cpp 96.15% <ø> (ø)
src/symtab/symbol.cpp 90.00% <ø> (ø)
src/symtab/symbol_properties.cpp 46.87% <ø> (-0.07%) ⬇️
src/symtab/symbol_properties.hpp 91.30% <ø> (ø)
src/visitors/perf_visitor.cpp 71.42% <ø> (+0.59%) ⬆️
src/visitors/perf_visitor.hpp 94.44% <ø> (ø)
src/visitors/localize_visitor.cpp 87.50% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bbpbuildbot

bbpbuildbot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #73830 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino force-pushed the remove_unused_token branch from 116357b to 6cd83f1 Compare September 29, 2022 09:01
@alkino alkino mentioned this pull request Sep 29, 2022
Closed
@bbpbuildbot

bbpbuildbot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #76441 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #76445 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk
pramodk approved these changes Sep 29, 2022
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pramodk pramodk changed the title Remove token that have never be implemented in nrn Remove token that have never be implemented in nrn: STEPPED / TERMINAL / PLOT / SENS / SECTION Sep 29, 2022
@pramodk pramodk merged commit 7b20833 into master Sep 29, 2022
@pramodk pramodk deleted the remove_unused_token branch September 29, 2022 22:14
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
@alkino
Remove token that have never be implemented in nrn: STEPPED / TERMINA…
14b1e4d 
…L / PLOT / SENS / SECTION (BlueBrain/nmodl#926)

* Following constructs are no longer relevant in the NEURON context:
   STEPPED / TERMINAL / PLOT / SENS / SECTION
* See discussion in neuronsimulator/nrnBlueBrain/nmodl#1974

NMODL Repo SHA: BlueBrain/nmodl@7b20833
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pramodk pramodk pramodk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alkino @bbpbuildbot @codecov-commenter @pramodk