Skip to content

Fix #1765: Return properly for errors in nrniv -c#1871

Merged
alexsavulescu merged 7 commits into
masterfrom
weji/nrniv_exitcode
Jun 24, 2022
Merged

Fix #1765: Return properly for errors in nrniv -c#1871
alexsavulescu merged 7 commits into
masterfrom
weji/nrniv_exitcode

Conversation

@WeinaJi

@WeinaJi WeinaJi commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@WeinaJi WeinaJi force-pushed the weji/nrniv_exitcode branch from d68be43 to adf92a8 Compare June 22, 2022 17:34
@WeinaJi WeinaJi mentioned this pull request Jun 22, 2022
Open
@azure-pipelines

azure-pipelines Bot commented Jun 22, 2022

Copy link
Copy Markdown

✔️ adf92a8e77fb86760b68c033d875582da861d721 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Jun 23, 2022

Copy link
Copy Markdown

✔️ 2c32be65f1a0b291d61f490d461e2e5197c4f9a9 -> Azure artifacts URL

@WeinaJi WeinaJi changed the title Fix #1765: Return properly for errors in nrniv -c [live-debug-ci] Fix #1765: Return properly for errors in nrniv -c Jun 24, 2022
@WeinaJi WeinaJi force-pushed the weji/nrniv_exitcode branch from 2c32be6 to 0933bb2 Compare June 24, 2022 07:44
@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ 0933bb2 -> Azure artifacts URL

nrnhines
nrnhines approved these changes Jun 24, 2022
View reviewed changes

@nrnhines nrnhines left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeinaJi WeinaJi changed the title [live-debug-ci] Fix #1765: Return properly for errors in nrniv -c Fix #1765: Return properly for errors in nrniv -c Jun 24, 2022
@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ 4ae451c -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ f1d74c9 -> Azure artifacts URL

@WeinaJi WeinaJi changed the title Fix #1765: Return properly for errors in nrniv -c [live-debug-ci] Fix #1765: Return properly for errors in nrniv -c Jun 24, 2022
@codecov-commenter

codecov-commenter commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1871 (ff97f53) into master (4a5867f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1871   +/-   ##
=======================================
  Coverage   47.12%   47.13%           
=======================================
  Files         543      543           
  Lines      112916   112917    +1     
=======================================
+ Hits        53217    53224    +7     
+ Misses      59699    59693    -6
Impacted Files Coverage Δ
src/oc/hoc.cpp 68.18% <100.00%> (+0.85%) ⬆️
src/oc/math.cpp 60.41% <100.00%> (+0.84%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ 8d45199 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ 9645972 -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ 74d02bb -> Azure artifacts URL

@azure-pipelines

azure-pipelines Bot commented Jun 24, 2022

Copy link
Copy Markdown

✔️ ff97f53 -> Azure artifacts URL

@WeinaJi WeinaJi changed the title [live-debug-ci] Fix #1765: Return properly for errors in nrniv -c Fix #1765: Return properly for errors in nrniv -c Jun 24, 2022
@alexsavulescu alexsavulescu merged commit 68923c0 into master Jun 24, 2022
@alexsavulescu alexsavulescu deleted the weji/nrniv_exitcode branch June 24, 2022 19:09
@alexsavulescu

alexsavulescu commented Jun 25, 2022

Copy link
Copy Markdown
Member

I thought I had run the nrn-modeldb-ci against this, but the CI proves me wrong. From today's run: https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/2559271308
zip here:
8.1.0-vs-9.0.dev-10-g68923c00.zip

This was referenced Jun 25, 2022
Merged
Open
alexsavulescu added a commit that referenced this pull request Jun 27, 2022
@alexsavulescu
errcheck: default to errno, fallback to fe_except if not set (#1882)
8f8917e 
* fix regression from #1871
* clear FE exceptions as well
* special case for MinGW (numerics lib not up to standard)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrnhines nrnhines nrnhines approved these changes
@alexsavulescu alexsavulescu alexsavulescu approved these changes

Assignees

No one assigned

Labels

hackron2022

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WeinaJi @codecov-commenter @alexsavulescu @nrnhines