Skip to content

errcheck: default to errno, fallback to fe_except if not set#1882

Merged
alexsavulescu merged 4 commits into
masterfrom
errswitch
Jun 27, 2022
Merged

errcheck: default to errno, fallback to fe_except if not set#1882
alexsavulescu merged 4 commits into
masterfrom
errswitch

Conversation

@alexsavulescu

Copy link
Copy Markdown
Member

following #1871 (comment)

@alexsavulescu alexsavulescu marked this pull request as draft June 25, 2022 12:47
@codecov-commenter

codecov-commenter commented Jun 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1882 (c2f9f6b) into master (68923c0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
+ Coverage   47.13%   47.17%   +0.04%     
==========================================
  Files         543      543              
  Lines      112917   112918       +1     
==========================================
+ Hits        53224    53270      +46     
+ Misses      59693    59648      -45     
Impacted Files Coverage Δ
src/oc/math.cpp 61.22% <100.00%> (+0.80%) ⬆️
src/parallel/bbs.cpp 76.27% <0.00%> (+1.69%) ⬆️
src/parallel/bbssrvmpi.cpp 47.56% <0.00%> (+6.09%) ⬆️
src/parallel/bbsclimpi.cpp 59.19% <0.00%> (+8.62%) ⬆️
src/nrnmpi/bbsmpipack.cpp 92.19% <0.00%> (+10.24%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@alexsavulescu alexsavulescu changed the title errcheck: default to errno, fallback to fe_except if not set errcheck: default to errno, fallback to fe_except if not set live-debug-win Jun 25, 2022
@azure-pipelines

Copy link
Copy Markdown

✔️ c2f9f6b -> Azure artifacts URL

@alexsavulescu

alexsavulescu commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

Azure artifacts URL

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/2564365737

LE: regression fixed

@alexsavulescu alexsavulescu marked this pull request as ready for review June 26, 2022 18:57
@alexsavulescu alexsavulescu changed the title errcheck: default to errno, fallback to fe_except if not set live-debug-win errcheck: default to errno, fallback to fe_except if not set Jun 26, 2022

@WeinaJi WeinaJi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines

Copy link
Copy Markdown

✔️ 3978069 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 8f8917e into master Jun 27, 2022
@alexsavulescu alexsavulescu deleted the errswitch branch June 27, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants