Skip to content

fix typo#9527

Merged
normanmaurer merged 5 commits intonetty:4.1from
KangZhiDong:4.1
Oct 9, 2019
Merged

fix typo#9527
normanmaurer merged 5 commits intonetty:4.1from
KangZhiDong:4.1

Conversation

@KangZhiDong
Copy link
Copy Markdown
Contributor

No description provided.

@netty-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

@normanmaurer
Copy link
Copy Markdown
Member

@KangZhiDong please fix check style

HttpConversionUtil.java:125: Line is longer than 120 characters (found 121)
@KangZhiDong
Copy link
Copy Markdown
Contributor Author

@KangZhiDong please fix check style

now is ok

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

@KangZhiDong
Copy link
Copy Markdown
Contributor Author

@netty-bot test this please

/code/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java:125: trailing whitespace [RegexpSingleline] .
i have modified for the second time

fix trailing whitespace
@KangZhiDong
Copy link
Copy Markdown
Contributor Author

@netty-bot test this please

This is really rigorous

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

1 similar comment
@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

Copy link
Copy Markdown
Member

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@normanmaurer normanmaurer merged commit bd8cea6 into netty:4.1 Oct 9, 2019
@normanmaurer
Copy link
Copy Markdown
Member

@KangZhiDong thanks a lot!

@normanmaurer normanmaurer added this to the 4.1.43.Final milestone Oct 9, 2019
normanmaurer pushed a commit that referenced this pull request Oct 9, 2019
Motivation:

We should have correct docs without typos

Modification:

Fix typos and spelling

Result:

More correct docs
dalaro added a commit to dalaro/netty that referenced this pull request Apr 7, 2020
Compared against 4.1.25.6.dse, this tag cherry-picks upstream commits
that fixed bugs in HttpObjectDecoder/HttpRequestDecoder, plus two
intermediate refactoring commits that indirectly affect those bugfix
commits.

What follows is a list of PR links, issue links, CVE links, and hashes
associated with the cherry-picked commits.

Verify we do not receive multiple content-length headers or a content-length and transfer-encoding: chunked header when using HTTP/1.1 (netty#9865)
	https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7238
	netty#9861
	netty#9865

	8494b04

Detect missing colon when parsing http headers with no value (netty#9871)
	GHSA-cqqj-4p63-rrmm
	netty#9866
	netty#9871

	a7c18d4

Fix typos in javadocs (netty#9527)
	skipped

Correctly handle whitespaces in HTTP header names as defined by RFC7230#section-3.2.4 (netty#9585)
	https://nvd.nist.gov/vuln/detail/CVE-2019-16869
	netty#9571
	netty#9585

	39cafcb

Use `AppendableCharSequence.charAtUnsafe(int)` in `HttpObjectDecoder` (netty#9492)
	netty#9492

	85fcf4e

use checkPositive/checkPositiveOrZero (netty#8835)
	netty#8835

	4c64c98

HttpObjectDecoder ignores HTTP trailer header when empty line is rece… (netty#8799)
	netty#8736
	netty#8799

	91d3920
dalaro added a commit to dalaro/netty that referenced this pull request Apr 7, 2020
Compared against 4.1.34.2.dse, this tag cherry-picks upstream commits
that fixed bugs in HttpObjectDecoder/HttpRequestDecoder, plus two
intermediate refactoring commits that indirectly affect those bugfix
commits.

What follows is a list of PR links, issue links, CVE links, and hashes
associated with the cherry-picked commits.

Verify we do not receive multiple content-length headers or a content-length and transfer-encoding: chunked header when using HTTP/1.1 (netty#9865)
	https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7238
	netty#9861
	netty#9865

	8494b04

Detect missing colon when parsing http headers with no value (netty#9871)
	https://nvd.nist.gov/vuln/detail/CVE-2019-20444
	netty#9866
	netty#9871

	a7c18d4

Fix typos in javadocs (netty#9527)
	skipped

Correctly handle whitespaces in HTTP header names as defined by RFC7230#section-3.2.4 (netty#9585)
	https://nvd.nist.gov/vuln/detail/CVE-2019-16869
	netty#9571
	netty#9585

	39cafcb

Use `AppendableCharSequence.charAtUnsafe(int)` in `HttpObjectDecoder` (netty#9492)
	netty#9492

	85fcf4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants