Skip to content

use checkPositive/checkPositiveOrZero#8835

Merged
normanmaurer merged 4 commits intonetty:masterfrom
thinkerou:p
Feb 4, 2019
Merged

use checkPositive/checkPositiveOrZero#8835
normanmaurer merged 4 commits intonetty:masterfrom
thinkerou:p

Conversation

@thinkerou
Copy link
Copy Markdown
Contributor

Motivation:

use checkPositive/checkPositiveOrZero

@netty-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot Test this please

@thinkerou
Copy link
Copy Markdown
Contributor Author

@normanmaurer done, thanks!

@normanmaurer
Copy link
Copy Markdown
Member

@netty-bot test this please

@normanmaurer normanmaurer merged commit db79983 into netty:master Feb 4, 2019
@normanmaurer normanmaurer added this to the 4.1.34.Final milestone Feb 4, 2019
@normanmaurer normanmaurer self-assigned this Feb 4, 2019
normanmaurer pushed a commit that referenced this pull request Feb 4, 2019
Motivation:

We can replace some "hand-rolled" integer checks with our own static utility method to simplify the code.

Modifications:

Use methods provided by `ObjectUtil`.

Result:

Cleaner code and less duplication
@normanmaurer
Copy link
Copy Markdown
Member

Also cherry-picked into 4.1 (4c64c98)

dalaro added a commit to dalaro/netty that referenced this pull request Apr 7, 2020
Compared against 4.1.25.6.dse, this tag cherry-picks upstream commits
that fixed bugs in HttpObjectDecoder/HttpRequestDecoder, plus two
intermediate refactoring commits that indirectly affect those bugfix
commits.

What follows is a list of PR links, issue links, CVE links, and hashes
associated with the cherry-picked commits.

Verify we do not receive multiple content-length headers or a content-length and transfer-encoding: chunked header when using HTTP/1.1 (netty#9865)
	https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7238
	netty#9861
	netty#9865

	8494b04

Detect missing colon when parsing http headers with no value (netty#9871)
	GHSA-cqqj-4p63-rrmm
	netty#9866
	netty#9871

	a7c18d4

Fix typos in javadocs (netty#9527)
	skipped

Correctly handle whitespaces in HTTP header names as defined by RFC7230#section-3.2.4 (netty#9585)
	https://nvd.nist.gov/vuln/detail/CVE-2019-16869
	netty#9571
	netty#9585

	39cafcb

Use `AppendableCharSequence.charAtUnsafe(int)` in `HttpObjectDecoder` (netty#9492)
	netty#9492

	85fcf4e

use checkPositive/checkPositiveOrZero (netty#8835)
	netty#8835

	4c64c98

HttpObjectDecoder ignores HTTP trailer header when empty line is rece… (netty#8799)
	netty#8736
	netty#8799

	91d3920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants